cmake: Remove NetBSD-specific workaround from `add_boost_if_needed` #35165

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:260427-boost-netbsd changing 1 files +0 −11
  1. hebasto commented at 9:54 AM on April 27, 2026: member

    The patched package boost-1.90.0 is available as of the pkgsrc-2026Q1 release.

  2. cmake: Remove NetBSD-specific workaround from `add_boost_if_needed`
    The patched package is available as of the `pkgsrc-2026Q1` release.
    e2ef54b8ba
  3. hebasto added the label Build system on Apr 27, 2026
  4. DrahtBot commented at 9:54 AM on April 27, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK davidgumberg

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. davidgumberg commented at 10:56 PM on April 28, 2026: contributor

    Tested ACK https://github.com/bitcoin/bitcoin/pull/35165/commits/e2ef54b8ba8de7ce1d7b1b04c3e28b08c3fa3816

    This branch works on a fresh install of NetBSD 10.1.

    One small caveat is that users may have a /usr/pkg/etc/pkgin/repositories.conf pinned to an earlier quarterly, e.g.

    https://ftp.netbsd.org/pub/pkgsrc/packages/NetBSD/x86_64/10.0_2025Q4/All
    

    so maybe a note in doc/build-netbsd.md or in the release notes about the minimum supported netbsd version, but I'm also OK as-is as I suspect that not many users do this but I am unfamiliar.

  6. hebasto commented at 7:11 AM on April 29, 2026: member

    One small caveat is that users may have a /usr/pkg/etc/pkgin/repositories.conf pinned to an earlier quarterly, e.g.

    https://ftp.netbsd.org/pub/pkgsrc/packages/NetBSD/x86_64/10.0_2025Q4/All
    

    so maybe a note in doc/build-netbsd.md or in the release notes about the minimum supported netbsd version, but I'm also OK as-is as I suspect that not many users do this but I am unfamiliar.

    Our documentation implicitly relies on OS default settings.

    The build notes for *BSD systems are maintained to be correct for the release explicitly mentioned at their top. However, we do our best to ensure that Bitcoin Core builds and runs on all supported releases, which is currently true except for OpenBSD.

    If you believe that our *BSD build notes could be improved, a PR is always welcome :)


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-01 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me