guix: add -Wl,--icf=safe to darwin build #35197

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:lld_icf_safe changing 1 files +1 −0
  1. fanquake commented at 9:38 AM on May 3, 2026: member

    --icf=safe Enable safe identical code folding.

    This reduces the size of bitcoind by ~0.5mb, and bitcoin-qt by 1.3mb (aarch64-apple-darwin).

    This option exists for lld, which is why it's only added for darwin builds.

  2. DrahtBot added the label Build system on May 3, 2026
  3. DrahtBot commented at 9:39 AM on May 3, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35197.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  4. DrahtBot added the label CI failed on May 3, 2026
  5. DrahtBot commented at 10:55 AM on May 3, 2026: contributor

    <!--85328a0da195eb286784d51f73fa0af9-->

    🚧 At least one of the CI tasks failed. <sub>Task i686, no IPC: https://github.com/bitcoin/bitcoin/actions/runs/25275669000/job/74105140405</sub> <sub>LLM reason (✨ experimental): CI failed because the sock_tests test in the “Bitcoin Core Test Suite” failed (ctest reported 1 failing test out of 296).</sub>

    <details><summary>Hints</summary>

    Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

    </details>

  6. luke-jr referenced this in commit bea657ca5b on May 4, 2026
  7. fanquake force-pushed on May 4, 2026
  8. fanquake force-pushed on May 6, 2026
  9. DrahtBot removed the label CI failed on May 6, 2026
  10. fanquake force-pushed on May 8, 2026
  11. guix: add -Wl,--icf=safe to darwin build
    > --icf=safe
    >    Enable safe identical code folding.
    
    This reduces the size of bitcoind by ~0.5mb, and bitcoin-qt by 1.3mb
    (aarch64-apple-darwin).
    aa3bbe2ea2
  12. fanquake marked this as ready for review on May 11, 2026
  13. fanquake force-pushed on May 11, 2026
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-11 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me