When loading a wallet, updating the state based on the chain data prior to AttachChain results in some blocks being missed, which leads to inconsistent state information that can cause assertion failures. Moving the state updating inside of AttachChain after the chain notifications handler has been attached ensures that the state will always be up to date with the tip that the wallet is tracking.
Fixes #34599
Updating transactions against the current chain state can only be done
in AttachChain after chain notifications have been attached. AttachChain
will guarantee that any blocks missing between the stored best block and
the current tip are rescanned, and any blocks connected during
AttachChain will be processed after loading completes.
This fixes an issue where tx states were updated with no guarantee that
any blocks connected prior to AttachChain are scanned, resulting in
incorrect tx states.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35294.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process. A summary of reviews will appear here.
<!--5faf32d7da4f0f540f40219e4f7537a3-->