ci: Fix `path` input for vcpkg downloads cache #35349
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:260521-vcpkg-cache changing 1 files +2 −1-
hebasto commented at 5:51 PM on May 21, 2026: member
-
e4f1e43103
ci: Fix `path` input for vcpkg downloads cache
The `path` inputs for the `cache/save` and `cache/restore` actions must have identical content.
- hebasto added the label Windows on May 21, 2026
- hebasto added the label Tests on May 21, 2026
-
DrahtBot commented at 5:51 PM on May 21, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35349.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK willcl-ark, maflcko If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- willcl-ark approved
-
willcl-ark commented at 7:41 PM on May 21, 2026: member
ACK e4f1e43103c
So the coment was being treated as part of the path string? 🤦🏼
-
maflcko commented at 7:43 PM on May 21, 2026: member
lgtm ACK e4f1e43103cf3c6d6417f5ad2ac1301bcc52696f
-
hebasto commented at 10:21 PM on May 21, 2026: member
So the coment was being treated as part of the path string? 🤦🏼
The "pipe" character (
|) denotes a literal block scalar, which includes the whole indented text. - hebasto merged this on May 22, 2026
- hebasto closed this on May 22, 2026
-
fanquake commented at 8:55 AM on May 22, 2026: member
The "pipe" character (|) denotes a literal block scalar, which includes the whole indented text.
This should have been part of either the commit message, or the pr description. Looking at this essentially move-only diff, it's not obvious why this was broken, or why this was the fix.
-
maflcko commented at 9:02 AM on May 22, 2026: member
The "pipe" character (|) denotes a literal block scalar, which includes the whole indented text.
This should have been part of either the commit message, or the pr description. Looking at this essentially move-only diff, it's not obvious why this was broken, or why this was the fix.
For fun, I asked some LLMs (google, openai) to review the original pr (just "review this:
pr.diff") and neither gemma 4, nor any gemini model found the issue, only gtp-5.4...Unrelated: Could probably use this trick in a xz-style backdoor, if there are projects using yaml in their build system ... :thinking:
- hebasto deleted the branch on May 22, 2026
