depends: Drop trailing slash from `CMAKE_INSTALL_LIBDIR` #35463

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:260604-depends-slash changing 1 files +1 −1
  1. hebasto commented at 1:46 PM on June 4, 2026: member
    1. The trailing slash is redundant.
    2. It causes CMP0177-specifc warnings when using CMake >=3.31.

    On the master branch:

    $ gmake -C depends freetype_configured
    gmake: Entering directory '/home/hebasto/dev/bitcoin/depends'
    Extracting freetype...
    /home/hebasto/dev/bitcoin/depends/sources/freetype-2.11.1.tar.gz: OK
    Preprocessing freetype...
    patching file CMakeLists.txt
    Configuring freetype...
    -- The C compiler identification is GNU 15.2.0
    -- Detecting C compiler ABI info
    -- Detecting C compiler ABI info - done
    -- Check for working C compiler: /usr/bin/gcc - skipped
    -- Detecting C compile features
    -- Detecting C compile features - done
    -- Looking for unistd.h
    -- Looking for unistd.h - found
    -- Looking for fcntl.h
    -- Looking for fcntl.h - found
    CMake Warning (dev) at CMakeLists.txt:577 (install):
      Policy CMP0177 is not set: install() DESTINATION paths are normalized.  Run
      "cmake --help-policy CMP0177" for policy details.  Use the cmake_policy
      command to set the policy and suppress this warning.
    This warning is for project developers.  Use -Wno-dev to suppress it.
    
    CMake Warning (dev) at CMakeLists.txt:596 (install):
      Policy CMP0177 is not set: install() DESTINATION paths are normalized.  Run
      "cmake --help-policy CMP0177" for policy details.  Use the cmake_policy
      command to set the policy and suppress this warning.
    This warning is for project developers.  Use -Wno-dev to suppress it.
    
    CMake Warning (dev) at CMakeLists.txt:601 (install):
      Policy CMP0177 is not set: install() DESTINATION paths are normalized.  Run
      "cmake --help-policy CMP0177" for policy details.  Use the cmake_policy
      command to set the policy and suppress this warning.
    This warning is for project developers.  Use -Wno-dev to suppress it.
    
    -- Configuring done (0.2s)
    -- Generating done (0.0s)
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_EXPORT_NO_PACKAGE_REGISTRY
    
    
    -- Build files have been written to: /home/hebasto/dev/bitcoin/depends/work/build/x86_64-pc-linux-gnu/freetype/2.11.1-0539b8d2229/build
    gmake: Leaving directory '/home/hebasto/dev/bitcoin/depends'
    

    With this PR:

    $ gmake -C depends freetype_configured
    gmake: Entering directory '/home/hebasto/dev/bitcoin/depends'
    Extracting freetype...
    /home/hebasto/dev/bitcoin/depends/sources/freetype-2.11.1.tar.gz: OK
    Preprocessing freetype...
    patching file CMakeLists.txt
    Configuring freetype...
    -- The C compiler identification is GNU 15.2.0
    -- Detecting C compiler ABI info
    -- Detecting C compiler ABI info - done
    -- Check for working C compiler: /usr/bin/gcc - skipped
    -- Detecting C compile features
    -- Detecting C compile features - done
    -- Looking for unistd.h
    -- Looking for unistd.h - found
    -- Looking for fcntl.h
    -- Looking for fcntl.h - found
    -- Configuring done (0.2s)
    -- Generating done (0.0s)
    CMake Warning:
      Manually-specified variables were not used by the project:
    
        CMAKE_EXPORT_NO_PACKAGE_REGISTRY
    
    
    -- Build files have been written to: /home/hebasto/dev/bitcoin/depends/work/build/x86_64-pc-linux-gnu/freetype/2.11.1-c25288632f9/build
    gmake: Leaving directory '/home/hebasto/dev/bitcoin/depends'
    
  2. depends: Drop trailing slash from `CMAKE_INSTALL_LIBDIR`
    1. The trailing slash is redundant.
    2. It causes warnings when using CMake >=3.31:
    ```
    CMake Warning (dev) at CMakeLists.txt:596 (install):
      Policy CMP0177 is not set: install() DESTINATION paths are normalized.  Run
      "cmake --help-policy CMP0177" for policy details.  Use the cmake_policy
      command to set the policy and suppress this warning.
    This warning is for project developers.  Use -Wno-dev to suppress it.
    
    ```
    2cf2b22ff1
  3. hebasto added the label Build system on Jun 4, 2026
  4. DrahtBot commented at 1:47 PM on June 4, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35463.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK ryanofsky

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. ryanofsky approved
  6. ryanofsky commented at 6:43 PM on June 16, 2026: contributor

    Code review ACK 2cf2b22ff1b0445283ad0e80d1073c85eb98e84a. Seems good to clean up this warning, and change is a simplification

  7. fanquake commented at 6:30 AM on June 17, 2026: member

    Guix Build (x86_64):

    c80877546fcaf4f1e7478bedeece921458fe675b81e832d84bf3577ed0baad51  guix-build-2cf2b22ff1b0/output/aarch64-linux-gnu/SHA256SUMS.part
    65948b5e5f7441c302a4dff4bfac9e68bb5b4822f28a7ea17e8220b2dd206d55  guix-build-2cf2b22ff1b0/output/aarch64-linux-gnu/bitcoin-2cf2b22ff1b0-aarch64-linux-gnu-debug.tar.gz
    e5b86fea04cedd9debc52e25a8950552f54855756c4d4ff1317e2264fe6e6c62  guix-build-2cf2b22ff1b0/output/aarch64-linux-gnu/bitcoin-2cf2b22ff1b0-aarch64-linux-gnu.tar.gz
    2ffc264e0f5d43cf3ea41f495c7f0399bbedaf8ee2b166ddf636c1108131351b  guix-build-2cf2b22ff1b0/output/arm-linux-gnueabihf/SHA256SUMS.part
    b7ff485172beaf155739f484976ff4804faa5126f840cc0d7ae424f65f12b153  guix-build-2cf2b22ff1b0/output/arm-linux-gnueabihf/bitcoin-2cf2b22ff1b0-arm-linux-gnueabihf-debug.tar.gz
    870232ca0ff999c468ed189a42b2de8e10b3628328bbce8806c122ea05ed4b5c  guix-build-2cf2b22ff1b0/output/arm-linux-gnueabihf/bitcoin-2cf2b22ff1b0-arm-linux-gnueabihf.tar.gz
    fafda54454c72273760d64e16a3d4ea4e202936669a5d4897eba3729267fba48  guix-build-2cf2b22ff1b0/output/arm64-apple-darwin/SHA256SUMS.part
    8cfa868eae8a54f4edf4295bebd3dbf09b2b08af995aa3411130f37952943520  guix-build-2cf2b22ff1b0/output/arm64-apple-darwin/bitcoin-2cf2b22ff1b0-arm64-apple-darwin-codesigning.tar.gz
    0792877e1b8870599937f10cb5fd10cf2706d61da7905718dd9498bf5b8b6b7c  guix-build-2cf2b22ff1b0/output/arm64-apple-darwin/bitcoin-2cf2b22ff1b0-arm64-apple-darwin-unsigned.tar.gz
    9635586ef35091f6f764936659e29f5dc4e59a46233ffa8ae3123b2a6c6a9b4d  guix-build-2cf2b22ff1b0/output/arm64-apple-darwin/bitcoin-2cf2b22ff1b0-arm64-apple-darwin-unsigned.zip
    0b83edaa2423cb8744369c7252351cd3110bb3f27a7bb50415d0c8bd16ceeae1  guix-build-2cf2b22ff1b0/output/dist-archive/bitcoin-2cf2b22ff1b0.tar.gz
    26ac2d5213f61850f1c5664e5ff34b34cbe7d492041d7de67b9030e3a71e8416  guix-build-2cf2b22ff1b0/output/powerpc64-linux-gnu/SHA256SUMS.part
    61244cda2d7c710a8cccd3e9652348cbb23b832bfe0871434d4718f4f3c964ea  guix-build-2cf2b22ff1b0/output/powerpc64-linux-gnu/bitcoin-2cf2b22ff1b0-powerpc64-linux-gnu-debug.tar.gz
    62c1b44d0476a2799de1b6078d4539e9f1169983f82b2f67aa2cb3acf09bcde8  guix-build-2cf2b22ff1b0/output/powerpc64-linux-gnu/bitcoin-2cf2b22ff1b0-powerpc64-linux-gnu.tar.gz
    a8c3be267e9965fb9630e002e7e44b7d09af278c7cb7f8df905a023684885dfe  guix-build-2cf2b22ff1b0/output/riscv64-linux-gnu/SHA256SUMS.part
    8f9fbeb1278cb299823de7de53c7bb63ec39bdd7712a1cd66dd683760bfe9a36  guix-build-2cf2b22ff1b0/output/riscv64-linux-gnu/bitcoin-2cf2b22ff1b0-riscv64-linux-gnu-debug.tar.gz
    e438c9572fe985e960030393348dfbf578f2ed22eefafbaaced643a24dbd8e07  guix-build-2cf2b22ff1b0/output/riscv64-linux-gnu/bitcoin-2cf2b22ff1b0-riscv64-linux-gnu.tar.gz
    51f58c8b3383fe24f36dec2799d4d21b784856b32a010c8cec9e5db63d33603a  guix-build-2cf2b22ff1b0/output/x86_64-apple-darwin/SHA256SUMS.part
    cb0af3c607673610188b3d7303068ea94f71ed68394bf8ea8d7b151eb9506f31  guix-build-2cf2b22ff1b0/output/x86_64-apple-darwin/bitcoin-2cf2b22ff1b0-x86_64-apple-darwin-codesigning.tar.gz
    73187d0770508fefdda2b3d8372b4e66df5fdca83a91b5bc7def3c5b93702936  guix-build-2cf2b22ff1b0/output/x86_64-apple-darwin/bitcoin-2cf2b22ff1b0-x86_64-apple-darwin-unsigned.tar.gz
    a7931f99ae91b75a84dc26e7af417f0c686d0f9c085968e6ffb21cac04d03af0  guix-build-2cf2b22ff1b0/output/x86_64-apple-darwin/bitcoin-2cf2b22ff1b0-x86_64-apple-darwin-unsigned.zip
    912a56785cfa390c656edbfae77dee3a1c499640075ae464598b861bb2591034  guix-build-2cf2b22ff1b0/output/x86_64-linux-gnu/SHA256SUMS.part
    dafba64380ce3350bbbc0b4c44e33735a1b71831f107e1aaa9c913771c3fedb9  guix-build-2cf2b22ff1b0/output/x86_64-linux-gnu/bitcoin-2cf2b22ff1b0-x86_64-linux-gnu-debug.tar.gz
    822bdee619f6b2a37a9787c1f385af9270d23b5e2d5d567a47f9433a0e39989a  guix-build-2cf2b22ff1b0/output/x86_64-linux-gnu/bitcoin-2cf2b22ff1b0-x86_64-linux-gnu.tar.gz
    ab5fc6bd6a7d2b77b18b5ca46d4d880ec7649b2a40d12c8bc149ff3f7bb4d6ea  guix-build-2cf2b22ff1b0/output/x86_64-w64-mingw32/SHA256SUMS.part
    f8ad8947c00dae7e76b60b50aceac0fa76d0ebab402bad06442341cc611a28ba  guix-build-2cf2b22ff1b0/output/x86_64-w64-mingw32/bitcoin-2cf2b22ff1b0-win64-codesigning.tar.gz
    e74d304fb39237017d3282c9028f287d27bf8ab22632094a689f2e2fd3e6bf42  guix-build-2cf2b22ff1b0/output/x86_64-w64-mingw32/bitcoin-2cf2b22ff1b0-win64-debug.zip
    56fd4de7a180dc76863b8a65c54bafa88a91c34728f0561604ee9193264307a0  guix-build-2cf2b22ff1b0/output/x86_64-w64-mingw32/bitcoin-2cf2b22ff1b0-win64-setup-unsigned.exe
    fca62cca9efa366e308c16905d6b00ed07d2e3e6f8d64f2c199f574072024fee  guix-build-2cf2b22ff1b0/output/x86_64-w64-mingw32/bitcoin-2cf2b22ff1b0-win64-unsigned.zip
    
  8. fanquake merged this on Jun 17, 2026
  9. fanquake closed this on Jun 17, 2026

  10. hebasto deleted the branch on Jun 17, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-07-01 05:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me