ci, iwyu: Request IPC file generation explicitly #35468

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:260605-iwyu-ipc changing 2 files +5 −2

hebasto commented at 4:37 PM on June 5, 2026: member

Fixes a part of #35361:

... other sporadic error output:

[1](https://github.com/bitcoin/bitcoin/actions/runs/26292243180/job/77395542650#step:11:11661)
error: no such file or directory: '/home/admin/actions-runner/_work/_temp/build/src/ipc/capnp/common.capnp.c++'
error: no input files
error: unable to handle compilation, expected exactly one compiler job in ''
error: no such file or directory: '/home/admin/actions-runner/_work/_temp/build/src/ipc/capnp/common.capnp.proxy-client.c++'
error: no input files
error: unable to handle compilation, expected exactly one compiler job in ''
error: no such file or directory: '/home/admin/actions-runner/_work/_temp/build/src/ipc/capnp/common.capnp.proxy-server.c++'
error: no input files
error: unable to handle compilation, expected exactly one compiler job in ''
error: no such file or directory: '/home/admin/actions-runner/_work/_temp/build/src/ipc/capnp/common.capnp.proxy-types.c++'
error: no input files

A draft, as it needs https://github.com/bitcoin-core/libmultiprocess/pull/291.

ci, iwyu: Request IPC file generation explicitly

Fixes a part of https://github.com/bitcoin/bitcoin/issues/35361.

f83600137c

hebasto added the label Tests on Jun 5, 2026
DrahtBot commented at 4:37 PM on June 5, 2026: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35468.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK ryanofsky

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #34914 (contrib: replace deprecated --deep codesign flag, fix accidental --verify skip on ci by Sjors)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
hebasto commented at 4:38 PM on June 5, 2026: member

Suggested by @ryanofsky in #35418#pullrequestreview-4437523909:

... why the IWYU job shouldn't do make bitcoin_ipc_headers bitcoin_ipc_test_headers to generate missing files.
in ci/test/03_test_script.sh:126 in f83600137c
```
 122 | @@ -123,7 +123,7 @@ cmake -S "$BASE_ROOT_DIR" -B "$BASE_BUILD_DIR" "${CMAKE_ARGS[@]}" || (
 123 |    false
 124 |  )
 125 |  
 126 | -if [[ "${GOAL}" != all && "${GOAL}" != codegen ]]; then
 127 | +if [[ "${GOAL}" != all && "${RUN_IWYU}" != true ]]; then
```
ryanofsky commented at 6:04 PM on June 5, 2026:

In commit "ci, iwyu: Request IPC file generation explicitly" (f83600137cf6926790417338adecf52fac208eaf)

Might be better to do:

if [[ "${GOAL}" != all && "${GOAL}" != *codegen* ]]; then

to avoid needing to reference the IWYU tool here or limit this specifically to IWYU.

Also IMO it would be nicer to just never prepend "all" here and make require CI jobs to specify "all" if they want it.

Type	Reviewers
ACK	ryanofsky

in ci/test/00_setup_env_native_iwyu.sh:23 in f83600137c

  16 | @@ -17,7 +17,10 @@ export RUN_FUNCTIONAL_TESTS=false
  17 |  export RUN_FUZZ_TESTS=false
  18 |  export RUN_CHECK_DEPS=false
  19 |  export RUN_IWYU=true
  20 | -export GOAL="codegen"
  21 | +# Adding non-codegen targets to the build goal is a workaround
  22 | +# for https://gitlab.kitware.com/cmake/cmake/-/work_items/27862
  23 | +# and https://github.com/bitcoin-core/libmultiprocess/issues/284.
  24 | +export GOAL="codegen bitcoin_ipc_headers bitcoin_ipc_test_headers"

ryanofsky commented at 6:20 PM on June 5, 2026:

In commit "ci, iwyu: Request IPC file generation explicitly" (f83600137cf6926790417338adecf52fac208eaf)

Could also add mptest_headers as an alternative to #35418

ryanofsky approved
ryanofsky commented at 6:21 PM on June 5, 2026: contributor

Code review ACK f83600137cf6926790417338adecf52fac208eaf. Thanks for implementing this
hebasto commented at 7:39 PM on June 5, 2026: member
The build log still shows several errors like the following:
```
/home/runner/work/_temp/build/src/ipc/capnp/init.capnp.h:18:10: fatal error: 'mp/proxy.capnp.h' file not found
   18 | #include <mp/proxy.capnp.h>
      |   
```
To fix these, https://github.com/bitcoin-core/libmultiprocess/pull/291 is required, as it introduces the necessary build target.

Contributors

Labels

Linked (view graph)

#35361 ci: spurious output / errors in IWYU job

ci, iwyu: Request IPC file generation explicitly #35468

Code Coverage & Benchmarks

Reviews

Conflicts