guix: CMake-related improvements #35503

hebasto commented at 7:44 AM on June 10, 2026: member

This PR introduces the following CMake-related improvements to contrib/guix/libexec/build.sh:

Drop redundant CMake --verbose options, as verbose output is already controlled by the VERBOSE environment variable, which has been exported since 85f4a4b0822e3aa10310c4623eff719f301e9263.
Fixes the "Ignoring empty string" CMake warning for non-Linux hosts.

hebasto added the label Build system on Jun 10, 2026

DrahtBot commented at 7:44 AM on June 10, 2026: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35503.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	fanquake

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#35499 (guix: add package.sh by fanquake)
#25573 (guix: produce a -static-pie bitcoind by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

hebasto commented at 9:30 AM on June 10, 2026: member

My Guix build:

x86_64
cf01ae224f97880bd2b04ef6ab91e381f43fc757d7bf3898d096a77aa0b9bf1e  guix-build-042e490e5f5c/output/aarch64-linux-gnu/SHA256SUMS.part
c92ea3ff6e251b20212d18c2bd62a8324b547df73cefafffd1f853939579fea0  guix-build-042e490e5f5c/output/aarch64-linux-gnu/bitcoin-042e490e5f5c-aarch64-linux-gnu-debug.tar.gz
e5bacec044148d61ea2c9957e6e583bb3dd543456564e325ef09be56f1699734  guix-build-042e490e5f5c/output/aarch64-linux-gnu/bitcoin-042e490e5f5c-aarch64-linux-gnu.tar.gz
859247a379f38a108e2682bc1e3fcfc043493bb2e819d6c905f1b5bd5c838909  guix-build-042e490e5f5c/output/arm-linux-gnueabihf/SHA256SUMS.part
25d50b317e7dd37c4be40eb3ae2281210173a6b7f01ee59580e60742966f418d  guix-build-042e490e5f5c/output/arm-linux-gnueabihf/bitcoin-042e490e5f5c-arm-linux-gnueabihf-debug.tar.gz
9b2030bf2a894a2d8ce8c43f1c3b8b13cdab5dc1f617b45416da6e406dd8333d  guix-build-042e490e5f5c/output/arm-linux-gnueabihf/bitcoin-042e490e5f5c-arm-linux-gnueabihf.tar.gz
411c52ff7e1a6d4121140447387534fdd32f4da1e7be1a24109366eca5b4ffd6  guix-build-042e490e5f5c/output/arm64-apple-darwin/SHA256SUMS.part
a2eeacab7fc3ee771f6d5f02d37bec02c005b1acefc33c36640e994a62b517fc  guix-build-042e490e5f5c/output/arm64-apple-darwin/bitcoin-042e490e5f5c-arm64-apple-darwin-codesigning.tar.gz
a54a2179f4d49c9618f168217d52b5810db4783d759b4e472e1d33d0f8299db4  guix-build-042e490e5f5c/output/arm64-apple-darwin/bitcoin-042e490e5f5c-arm64-apple-darwin-unsigned.tar.gz
3e4fff87938b0608e7f0132825f70e7316baa6f8ad7a6801023af9beebc7864a  guix-build-042e490e5f5c/output/arm64-apple-darwin/bitcoin-042e490e5f5c-arm64-apple-darwin-unsigned.zip
6aa5e339704ebb6b53c6221d0f1d10449ac65e5eef154b696575fbbb054bf871  guix-build-042e490e5f5c/output/dist-archive/bitcoin-042e490e5f5c.tar.gz
3b32334a9bce79c5918aeff94432895078491fcda9aa3d7be32b3a1386c3d596  guix-build-042e490e5f5c/output/powerpc64-linux-gnu/SHA256SUMS.part
dfbc8511814ffb7b62fc254e04d00350516f94544a54790e486de0e88a88fd29  guix-build-042e490e5f5c/output/powerpc64-linux-gnu/bitcoin-042e490e5f5c-powerpc64-linux-gnu-debug.tar.gz
03791fabb048062552278723d142bd7e81fa529247fc412f7c9742eef68fcf23  guix-build-042e490e5f5c/output/powerpc64-linux-gnu/bitcoin-042e490e5f5c-powerpc64-linux-gnu.tar.gz
32c78d78a556eed2271c9030396aca090e94c16f6bc84f1e4d1b24308b8e285d  guix-build-042e490e5f5c/output/riscv64-linux-gnu/SHA256SUMS.part
77aa860ee4968a6045d74f4dd368fe59231fa85202b5bab98063ed86865f6d8d  guix-build-042e490e5f5c/output/riscv64-linux-gnu/bitcoin-042e490e5f5c-riscv64-linux-gnu-debug.tar.gz
b7e495fa6fdeb4cc5ba06025d4ea232703bb86c659b588a6e5f71230e9c3e1fa  guix-build-042e490e5f5c/output/riscv64-linux-gnu/bitcoin-042e490e5f5c-riscv64-linux-gnu.tar.gz
2abdff430e26ecf4611805adbe06873533d64fc308d8f0c1ebcf794693ca98f1  guix-build-042e490e5f5c/output/x86_64-apple-darwin/SHA256SUMS.part
0e860c657f7a27cbe2bcd67f90555334136a93ca3a8a7b100e61db936f32e9ee  guix-build-042e490e5f5c/output/x86_64-apple-darwin/bitcoin-042e490e5f5c-x86_64-apple-darwin-codesigning.tar.gz
50a23f3dc96eb75689a8209eb2bb49fde078950acba6b39ab3e180b7008ff946  guix-build-042e490e5f5c/output/x86_64-apple-darwin/bitcoin-042e490e5f5c-x86_64-apple-darwin-unsigned.tar.gz
b4dcae3704b2b706e1cc3dd80ecc6aeb2f2eda3990397f61f7a0bb21a3a9aaa7  guix-build-042e490e5f5c/output/x86_64-apple-darwin/bitcoin-042e490e5f5c-x86_64-apple-darwin-unsigned.zip
78b6179c9dec799f7b613609f64b1c3f1c1c78ab9ff25763394ec642e15f2e3c  guix-build-042e490e5f5c/output/x86_64-linux-gnu/SHA256SUMS.part
aacaa9a3fe7d5bd5687de5ebf24148c10dc18875109fc94f15043ff339b06f3a  guix-build-042e490e5f5c/output/x86_64-linux-gnu/bitcoin-042e490e5f5c-x86_64-linux-gnu-debug.tar.gz
8512b511f05ba328b1420986461bbb76926df2df7a22978a4966b9a9afdecdca  guix-build-042e490e5f5c/output/x86_64-linux-gnu/bitcoin-042e490e5f5c-x86_64-linux-gnu.tar.gz
a0ca5e59050ddb913b4297040462f4058c8acafd6250b6dc01c82b3e4513e87c  guix-build-042e490e5f5c/output/x86_64-w64-mingw32/SHA256SUMS.part
2fd48645b9337effa806488bb04fd9658712add64c907a43dc0173f582e9ca91  guix-build-042e490e5f5c/output/x86_64-w64-mingw32/bitcoin-042e490e5f5c-win64-codesigning.tar.gz
945e73393a3052a906cb6246e17991b6af8aec22c4921270f1ebe96f0f8c1ac1  guix-build-042e490e5f5c/output/x86_64-w64-mingw32/bitcoin-042e490e5f5c-win64-debug.zip
5ef54d9248352798602badf7159fef5dfb3fafbf17f7380e5a5cf058f7587090  guix-build-042e490e5f5c/output/x86_64-w64-mingw32/bitcoin-042e490e5f5c-win64-setup-unsigned.exe
385b55f87889c7363c83825bf3761b590c843b143f7fe3b24968d687b277f0df  guix-build-042e490e5f5c/output/x86_64-w64-mingw32/bitcoin-042e490e5f5c-win64-unsigned.zip

fanquake commented at 8:30 AM on June 11, 2026: member

There's still an instance of --verbose in build.sh: https://github.com/bitcoin/bitcoin/blob/d0b8d445fb7a936d52f88c7d526184f97e462fa2/contrib/guix/libexec/build.sh#L293

in contrib/guix/libexec/build.sh:169 in 042e490e5f outdated

 165 | @@ -166,17 +166,17 @@ mkdir -p "$DISTSRC"
 166 |            -DWITH_CCACHE=OFF \
 167 |            -Werror=dev \
 168 |            ${CONFIGFLAGS} \
 169 | -          "${CMAKE_EXE_LINKER_FLAGS}"
 170 | +          ${CMAKE_EXE_LINKER_FLAGS+"$CMAKE_EXE_LINKER_FLAGS"}

fanquake commented at 8:31 AM on June 11, 2026:

042e490e5f5c9e81f5567ba9c2331e294e0d4cbc: You could add the output/context of what is being fixed, to the commit message.

fanquake commented at 9:13 AM on June 12, 2026:

To be clear, I meant add the actual Guix build output, rather than describing it. i.e:

HOSTS="arm64-apple-darwin" ./contrib/guix/guix-build
<>
make: Leaving directory '/bitcoin/depends'
CMake Warning:
  Ignoring empty string ("") provided on the command line.


-- The CXX compiler identification is Clang 19.1.7

However you can leave this as-is now.

hebasto force-pushed on Jun 11, 2026

hebasto commented at 9:22 AM on June 11, 2026: member

@fanquake

Thank you for the review. Your feedback has been addressed.

hebasto commented at 12:50 PM on June 11, 2026: member

My Guix build:

aarch64
2138d9a353e93bf717a04ad7d19a3fffecc83593b4b3701d99be0cfd5d99fe77  guix-build-6d963c83bb11/output/aarch64-linux-gnu/SHA256SUMS.part
e1e46d0d351462bb9a970be9f4036625b8abd5bae59d87eff2ece0f491895716  guix-build-6d963c83bb11/output/aarch64-linux-gnu/bitcoin-6d963c83bb11-aarch64-linux-gnu-debug.tar.gz
bb68f84672cfcc0069bdd83478ce5f3f5803724a991ff05bea047bc6923b8c30  guix-build-6d963c83bb11/output/aarch64-linux-gnu/bitcoin-6d963c83bb11-aarch64-linux-gnu.tar.gz
fa2a34791b2187c887a05b2b96aaf2ff7dcc81c44cd7bd0ccc5e614b89576d8c  guix-build-6d963c83bb11/output/arm-linux-gnueabihf/SHA256SUMS.part
561395e760dea0bc981a23dc2501b174e06f96b8aede4af69cdbec61cda41c35  guix-build-6d963c83bb11/output/arm-linux-gnueabihf/bitcoin-6d963c83bb11-arm-linux-gnueabihf-debug.tar.gz
8bfcf2987e89da03c740004b259de9a2a29a060b02df390673bee0f6a1c48cf8  guix-build-6d963c83bb11/output/arm-linux-gnueabihf/bitcoin-6d963c83bb11-arm-linux-gnueabihf.tar.gz
c0d6f88483c562f284806119f15c7521482755ff1469c400c8c3cd6357decd10  guix-build-6d963c83bb11/output/arm64-apple-darwin/SHA256SUMS.part
58c6f9df7dba539d3208fa24d5e2cf6129c1f42114d6ea6cf917add661d8a2b8  guix-build-6d963c83bb11/output/arm64-apple-darwin/bitcoin-6d963c83bb11-arm64-apple-darwin-codesigning.tar.gz
99c1885b12c048e6913c550bbadb18a442d9ab4413d50333f68fba9bb9907a95  guix-build-6d963c83bb11/output/arm64-apple-darwin/bitcoin-6d963c83bb11-arm64-apple-darwin-unsigned.tar.gz
8fdb2eff593086de04117c62b934e1443aa3e19d88eb681af0cee01fa66f0814  guix-build-6d963c83bb11/output/arm64-apple-darwin/bitcoin-6d963c83bb11-arm64-apple-darwin-unsigned.zip
87ab247b695d8a501e77b5cd3ef0c95f2aa968c9a63f09da7c20c9ddad8e7a14  guix-build-6d963c83bb11/output/dist-archive/bitcoin-6d963c83bb11.tar.gz
b82510995b5a9161b0f7b7b08fe510fd758069012fcf2791148f3cda28f7b39b  guix-build-6d963c83bb11/output/powerpc64-linux-gnu/SHA256SUMS.part
4c28895ba40e2cc168fdf054f288a3baa764543aa06198d9e1daf2b2d2c7058c  guix-build-6d963c83bb11/output/powerpc64-linux-gnu/bitcoin-6d963c83bb11-powerpc64-linux-gnu-debug.tar.gz
9d11be1a51b9f4672f6398e7bf7d0e9ad1c530198f0bfb2f66c55428f58d706a  guix-build-6d963c83bb11/output/powerpc64-linux-gnu/bitcoin-6d963c83bb11-powerpc64-linux-gnu.tar.gz
8a30b0f07dc31277a835d5f7683b56fbc104599bd084c364045557463b086ba8  guix-build-6d963c83bb11/output/riscv64-linux-gnu/SHA256SUMS.part
ccd1c5db6b2e56cd07a90dfa8f3ffba4910e14091e5d01ac46370ded94e75db7  guix-build-6d963c83bb11/output/riscv64-linux-gnu/bitcoin-6d963c83bb11-riscv64-linux-gnu-debug.tar.gz
9ac65d61017e9eef70b20d6ab0568f2f9e31c512e52fe42931821068046e7cd9  guix-build-6d963c83bb11/output/riscv64-linux-gnu/bitcoin-6d963c83bb11-riscv64-linux-gnu.tar.gz
98169cf3d056df1435ad6fe221343e25061e14e07488328e02bb73384d48edf2  guix-build-6d963c83bb11/output/x86_64-apple-darwin/SHA256SUMS.part
e692b4408ffcfed72a0f5fd6f578862e32fb5b93025d420cfdf3ee32e08d5937  guix-build-6d963c83bb11/output/x86_64-apple-darwin/bitcoin-6d963c83bb11-x86_64-apple-darwin-codesigning.tar.gz
9bdccd6dc6990dfb04bcb3ad3043d7e59687256a7dd470867d852e33be5420d1  guix-build-6d963c83bb11/output/x86_64-apple-darwin/bitcoin-6d963c83bb11-x86_64-apple-darwin-unsigned.tar.gz
997137eb7a7289a1b37831d61b18c7de5fdb44d1a99ac6991f4b0c046e9c91a6  guix-build-6d963c83bb11/output/x86_64-apple-darwin/bitcoin-6d963c83bb11-x86_64-apple-darwin-unsigned.zip
44855585afeabf2d7bf6781650d2a01a76e96af322c167394a010e401abb66c1  guix-build-6d963c83bb11/output/x86_64-linux-gnu/SHA256SUMS.part
08707b12c4eb07e3669bd82cd1a90e4f02eebe629f05a930a8214b86277640b3  guix-build-6d963c83bb11/output/x86_64-linux-gnu/bitcoin-6d963c83bb11-x86_64-linux-gnu-debug.tar.gz
358995281c6ba2788805a0f615db836fb3580252af9fb33890ddc8bf196078a6  guix-build-6d963c83bb11/output/x86_64-linux-gnu/bitcoin-6d963c83bb11-x86_64-linux-gnu.tar.gz
0fe9bb347a1d0ac3e7a7279d6b405553f4ccbf3bac371530efbfa79f52749b7a  guix-build-6d963c83bb11/output/x86_64-w64-mingw32/SHA256SUMS.part
7ea0862d6fee518e7d389cdd4979739f28726f6b26d199cb913f592b9ed77af5  guix-build-6d963c83bb11/output/x86_64-w64-mingw32/bitcoin-6d963c83bb11-win64-codesigning.tar.gz
191d245abda86c9578ddc76056425ad4e5b6f6edd2876e74cbbeed5cfa0a273c  guix-build-6d963c83bb11/output/x86_64-w64-mingw32/bitcoin-6d963c83bb11-win64-debug.zip
e1614a7f771523d446cf8482c5d52492431e26c337c1c592908fc1a55a216d4d  guix-build-6d963c83bb11/output/x86_64-w64-mingw32/bitcoin-6d963c83bb11-win64-setup-unsigned.exe
f7c97a77c3d54f7e54c617d1ed8538752becb01aeff60a7059b8530374b39c1a  guix-build-6d963c83bb11/output/x86_64-w64-mingw32/bitcoin-6d963c83bb11-win64-unsigned.zip

fanquake commented at 9:18 AM on June 12, 2026: member

ACK 6d963c83bb11168212b4878947dd5eaa2bcc0b89 - checked V=1 is still verbose, and no warning on non-Linux.

DrahtBot added the label Needs rebase on Jun 15, 2026

guix: Drop redundant CMake `--verbose` options

CMake's verbose output is already controlled by the `VERBOSE`
environment variable, which has been exported since commit 85f4a4b0822e.

2d86083fd4

guix: Fix "Ignoring empty string" CMake warning for non-Linux hosts

Using shell parameter expansion ensures that on non-Linux hosts the
build script won't pass an empty string argument to CMake. This resolves
the "Ignoring empty string" warning.

059edf1908

hebasto force-pushed on Jun 15, 2026

hebasto commented at 2:39 PM on June 15, 2026: member

Rebased to resolve a conflict with the merged bitcoin/bitcoin#35499.

DrahtBot removed the label Needs rebase on Jun 15, 2026

DrahtBot added the label CI failed on Jun 15, 2026

DrahtBot commented at 4:55 PM on June 15, 2026: contributor

🚧 At least one of the CI tasks failed. <sub>Task iwyu: https://github.com/bitcoin/bitcoin/actions/runs/27554030092/job/81469320250</sub> <sub>LLM reason (✨ experimental): CI failed because IWYU reported an include change was needed (Failure generated from IWYU).</sub>

<details><summary>Hints</summary>

Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.
A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.
An intermittent issue.

Leave a comment here, if you need help tracking down a confusing failure.

</details>

fanquake commented at 5:02 PM on June 15, 2026: member

ACK 059edf190897333781d74ec02b1faba6a67c2148

fanquake merged this on Jun 15, 2026

fanquake closed this on Jun 15, 2026

hebasto deleted the branch on Jun 15, 2026