http: Make class fields private or convert to struct #35829

pull hodlinator wants to merge 9 commits into bitcoin:master from hodlinator:pr/35182_suggestions changing 7 files +205 −204

hodlinator commented at 11:49 AM on July 28, 2026: contributor
- Makes HTTPResponse a struct since it is used that way. (https://github.com/bitcoin/bitcoin/pull/35182#discussion_r3336757663)
- Simplifies boolean logic in HTTPServer::DisconnectClients(). (https://github.com/bitcoin/bitcoin/pull/35182#discussion_r3336757663)
- Refactors HTTPRequest and HTTPRemoteClient to be more self-contained rather than having HTTPServer reach into the fields of other objects. (https://github.com/bitcoin/bitcoin/pull/35182#discussion_r3339543447, #35182 (review))
- Drop/rename http_bitcoin/bitcoin_http namespace - Will only do the rename or the dropping depending on reviewer feedback. (https://github.com/bitcoin/bitcoin/pull/35182#discussion_r3264510816)
Follow-up to #35182.
http: Make HTTPResponse a struct since all fields are public eeb972ced5

http: Make HTTPRequest fields private

Makes sense since they are only set by methods in the class itself, and already had accessors for most fields.

d354c09b14

http: Simplify boolean logic in HTTPServer::DisconnectClients() f7662a3b0c
http: Extract HTTPRemoteClient::MaybeDisconnect() from HTTPServer::DisconnectClients() adfd62c088
http: Extract Send() and Receive() from HTTPServer into HTTPRemoteClient 66aa0f707e
http: Replace HTTPServer::MaybeDispatchRequestsFromClient() with HTTPRemoteClient::ReadRequests() 9e31b88082
http: Make HTTPRemoteClient fields private 09f1d07f45

http: Rename http_bitcoin -> bitcoin_http

It's Bitcoin Core's implementation of the HTTP protocol, not HTTP protocol's implementation of bitcoin 402 payment required codes or anything like that.

3ccd2930f8

http: Drop bitcoin_http namespace

It was only used during #35182 to distinguish from libevent counterparts.

c2e4d5f58a

DrahtBot added the label RPC/REST/ZMQ on Jul 28, 2026
DrahtBot commented at 11:49 AM on July 28, 2026: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35829.



Reviews

See the guideline and AI policy for information on the review process. A summary of reviews will appear here.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #35828 (util: Make LineReader consistently use string_view by hodlinator)
- #35780 (http: linger-close after parse errors so clients can read the reply by b-l-u-e)
- #35735 (Add state to HTTPRequest by pinheadmz)
- #35592 (http: check rpcallowip immediately after accepting connection by pinheadmz)
- #26022 (Add util::ResultPtr class by ryanofsky)
- #25722 (refactor: Use util::Result class for wallet loading by ryanofsky)
- #25665 (refactor: Add util::Result failure types and ability to merge result values by ryanofsky)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
pinheadmz commented at 7:51 PM on July 28, 2026: member

Light code review, changes all look fine. It's all code style cleanups (thanks 😬) though without any obvious gain. Will review more thoroughly after more concept a-c-ks
DrahtBot commented at 11:10 PM on July 29, 2026: contributor



🐙 This pull request conflicts with the target branch and needs rebase.
DrahtBot added the label Needs rebase on Jul 29, 2026

Contributors

hodlinator

DrahtBot

pinheadmz

Labels

RPC/REST/ZMQ Needs rebase

Linked (view graph)

#35182 Replace libevent with our own HTTP and socket-handling implementation

http: Make class fields private or convert to struct #35829

Code Coverage & Benchmarks

Reviews

Conflicts