http: Improve HTTPRemoteClient::MaybeDisconnect() #36159

Issues

#35182 had 1 case where we flag a client for disconnect where we do not log the reason.

#35829 introduced the somewhat poorly named non-const HTTPRemoteClient::MaybeDisconnect(). It also lacks testing.

The control-flow in MaybeDisconnect()/ShouldDisconnect() is somewhat complex. #35829 (review)

Commits solving these issues in same order

• http: Add log message for remaining case where we set HTTPRemoteClient::m_disconnect = true
• refactor: Rename MaybeDisconnect() to ShouldDisconnect() and make it const
• test: Add test for behavior of ShouldDisconnect()
• refactor: Flatten control flow in ShouldDisconnect()

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--006a51241073e994b41acfe9ec718e94-->

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36159.

<!--021abf342d371248e50ceaed478a90ca-->

Reviews

See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

<!--5faf32d7da4f0f540f40219e4f7537a3-->

LLM Linter (✨ experimental)

Possible places where named args for integral literals may be used (e.g. func(x, /*named_arg=*/0) in C++, and func(x, named_arg=0) in Python):

• [CreateSock(0, 0, 0)] in src/test/httpserver_tests.cpp

^{2026-09-03 10:41:30}