ipc: use std::optional for checkSpawned(), add tests and rename arg -ipcfd to -ipcchild #35887

pull ViniciusCestarii wants to merge 3 commits into bitcoin:master from ViniciusCestarii:checkspawned-tests changing 6 files +63 −24
  1. ViniciusCestarii commented at 8:47 PM on August 4, 2026: contributor

    Implement proposed follow-ups on dicussion #35084 (review).

    • Add unit test for checkSpawned().
    • Make checkSpawned() return std::optionalmp::SocketId.
    • Rename -ipcfd to -ipcchild.
  2. ipc, refactor: return std::optional<mp::SocketId> from checkSpawned() bd3a38f10a
  3. ipc, refactor: rename arg -ipcfd to -ipcchild 8bca7555f8
  4. ipc, test: add checkSpawned() unit tests d01e65ccff
  5. DrahtBot added the label IPC on Aug 4, 2026
  6. DrahtBot commented at 8:47 PM on August 4, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/35887.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

    LLM Linter (✨ experimental)

    Possible places where comparison-specific test macros should replace generic comparisons:

    • [src/ipc/test/ipc_tests.cpp] BOOST_CHECK_THROW(process->checkSpawned(3, argv), std::runtime_error); -> consider BOOST_CHECK_EXCEPTION(..., std::runtime_error, HasReason("...")) to verify the specific failure message instead of only the generic exception type.

    <sup>2026-08-04 20:47:50</sup>


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-08-06 20:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me