When run in the GHA environment, there is no console attached, so Qt's stderrHasConsoleAttached() returns false and the entire test report is lost. Set QT_ASSUME_STDERR_HAS_CONSOLE=1 to override the detection, as documented in Qt's qlogging.cpp:
if (qEnvironmentVariableIntValue("QT_ASSUME_STDERR_HAS_CONSOLE"))
return true;
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36024.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline and AI policy for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | davidgumberg, maflcko |
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
When run in the GHA environment, there is no console attached, so Qt's
`stderrHasConsoleAttached()` returns false and the entire test report is
lost. Set `QT_ASSUME_STDERR_HAS_CONSOLE=1` to override the detection, as
documented in Qt's `qlogging.cpp`.
utACK https://github.com/bitcoin/bitcoin/pull/36024/commits/70701de7c55512b4c8dbc3eaca91659980bf5300
I'm a bit surprised to learn test_bitcoin-qt.exe is only run on the windows CI job.
I'm a bit surprised to learn
test_bitcoin-qt.exeis only run on the windows CI job.
It is also run on a bunch of Linux jobs. E.g. https://github.com/bitcoin/bitcoin/actions/runs/36113519701/job/108002133147#step:10:2715
229/378 Test [#221](/bitcoin-bitcoin/221/): test_bitcoin-qt ............................................................ Passed 3.40 sec
I'm a bit surprised to learn
test_bitcoin-qt.exeis only run on the windows CI job.It is also run on a bunch of Linux jobs. E.g. https://github.com/bitcoin/bitcoin/actions/runs/36113519701/job/108002133147#step:10:2715
229/378 Test [#221](/bitcoin-bitcoin/221/): test_bitcoin-qt ............................................................ Passed 3.40 sec
Gah, I grepped for test_bitcoin-qt.exe, at least i was technically correct in my comment :)
I guess this is only an issue for Windows then, all the other reports about it i've found are windows jobs, e.g.:
https://github.com/Mudlet/Mudlet/issues/9747 https://github.com/actions/runner-images/issues/1679
lgtm ACK 70701de7c55512b4c8dbc3eaca91659980bf5300