ci: Doc: Move all config comments right next to the option they explain #36052

pull maflcko wants to merge 2 commits into bitcoin:master from maflcko:2608-ci-doc-comments changing 26 files +101 −99
  1. maflcko commented at 11:19 AM on August 21, 2026: member

    This is a CI doc-style-cleanup. BITCOIN_CONFIG is a single manually-formatted large string. This is fine, but shellcheck doesn't like when trailing comments are added: SC2155 -- Declare and assign separately.

    Fix this style by using printf to format the single string. The second commit then moves the comments right into (or next to) the line that it concerns.

  2. ci: refactor: Use printf %q quoting for BITCOIN_CONFIG
    This refactor turns a long manually formatted and quoted string into one
    formatted and quoted by printf.
    fa5c10acec
  3. ci: Doc: Move all config comments right next to the option they explain fa03706fde
  4. DrahtBot renamed this:
    ci: Doc: Move all config comments right next to the option they explain
    ci: Doc: Move all config comments right next to the option they explain
    on Aug 21, 2026
  5. DrahtBot added the label Tests on Aug 21, 2026
  6. DrahtBot commented at 11:19 AM on August 21, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36052.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK hebasto

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #36033 ([wip,nomerge,rfc] build: Require C++23 compiler by maflcko)
    • #35957 (ci: Enable Boost.MultiIndex invariant-checking mode by hebasto)
    • #35468 (ci, iwyu: Request IPC file generation explicitly by hebasto)
    • #29700 (kernel, refactor: return error status on all fatal errors by ryanofsky)
    • #26022 (Add util::ResultPtr class by ryanofsky)
    • #25722 (refactor: Use util::Result class for wallet loading by ryanofsky)
    • #25665 (refactor: Add util::Result failure types and ability to merge result values by ryanofsky)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  7. hebasto approved
  8. hebasto commented at 10:50 AM on August 22, 2026: member

    ACK fa03706fdef52e85b36b758c5867519acfc32a70.

Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-08-24 13:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me