Closes #36755
To cover -rpcservertimeout behavior our test expected the Bitcoin Core HTTP server to disconnect the test framework client after the configured duration but also before a somewhat arbitrary upper bound. This was helpful during development of #35182 but has led to false negatives in CI on platforms that are just plain slow.
Solve the flakiness by simply deleting the test case. Note that a regression is still caught by both the functional test and unit test suite. #36159 added a mock clock in the unit test to assert the disconnect timing. A server with no timeout would also fail the functional test which will time out during sock.recv() waiting for the EOF.
Both regression test failures can be observed on top of this branch by disabling rpcservertimeout:
diff --git a/src/httpserver.cpp b/src/httpserver.cpp
index 069eace507..7a090c4ca8 100644
--- a/src/httpserver.cpp
+++ b/src/httpserver.cpp
@@ -1205,7 +1205,7 @@ bool HTTPRemoteClient::ShouldDisconnect(MockableSteadyClock::time_point now, std
"HTTP client idle timeout %s (id=%llu)",
m_origin,
m_id);
- return true;
+ return false;
// Disconnect this client because the server is shutting down and we need to
// disconnect all clients... Unless the client is still being handled by a
// worker thread, in which case we'd rather continue the I/O loop (but might
