[32.x] Bump to 32.0rc1 #36246

1. 
   sedited commented at 8:46 AM on September 14, 2026: contributor

   No description provided.

2. DrahtBot added the label Backport on Sep 14, 2026
3. 
   DrahtBot commented at 8:46 AM on September 14, 2026: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36246.

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline and AI policy for information on the review process.

   Type	Reviewers
   ACK	hebasto, fanquake

   If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

   <!--5faf32d7da4f0f540f40219e4f7537a3-->

4. build: Bump to 32.0rc1 b4eafed80e
5. release: Generate man pages 6f132cc337
6. release: Generate bitcoin.conf b8e7c8c575
7. doc: Point release notes to 32.0 wiki draft 27d0d4fb3a
8. sedited force-pushed on Sep 14, 2026
9. fanquake added this to the milestone 32.0 on Sep 14, 2026
10. DrahtBot added the label CI failed on Sep 14, 2026
11. 
    fanquake commented at 10:08 AM on September 14, 2026: member

    https://github.com/bitcoin/bitcoin/actions/runs/34824778560/job/103914394388?pr=36246#step:11:5620:

    + ./contrib/devtools/clang-format-diff.py -binary=clang-format-23 -p1 -i -v
    Formatting src/clientversion.cpp
    + git --no-pager diff --exit-code
    diff --git a/src/clientversion.cpp b/src/clientversion.cpp
    index 222dafb..1bb1332 100644
    --- a/src/clientversion.cpp
    +++ b/src/clientversion.cpp
    @@ -22,7 +22,6 @@ using util::Join;
     const std::string UA_NAME("Satoshi");
     
     
    -#include <bitcoin-build-info.h>
     // The <bitcoin-build-info.h>, which is generated by the build environment (cmake/script/GenerateBuildInfo.cmake),
     // could contain only one line of the following:
     //   - "#define BUILD_GIT_TAG ...", if the top commit is tagged
    ^^^ ⚠️ Failure generated from IWYU
    + echo '^^^ ⚠️ Failure generated from IWYU'
    + false
    

    Not sure why IWYU is failing. cc @hebasto.

12. in CMakeLists.txt:34 in 27d0d4fb3a outdated

      32 | +set(CLIENT_VERSION_MINOR 0)
      33 |  set(CLIENT_VERSION_BUILD 0)
      34 | -set(CLIENT_VERSION_RC 0)
      35 | -set(CLIENT_VERSION_IS_RELEASE "false")
      36 | +set(CLIENT_VERSION_RC 1)
      37 | +set(CLIENT_VERSION_IS_RELEASE "true")
    

    ---

    ---

    

    hebasto commented at 10:44 AM on September 14, 2026:

    Not sure why IWYU is failing. cc @hebasto.

    This change makes BUILD_GIT_COMMIT (defined in <bitcoin-build-info.h>) unused in src/clientversion.cpp, which causes IWYU to suggest removing #include <bitcoin-build-info.h>.

    Let's tell IWYU to always keep it:

    --- a/src/clientversion.cpp
    +++ b/src/clientversion.cpp
    @@ -22,7 +22,7 @@ using util::Join;
     const std::string UA_NAME("Satoshi");
     
     
    -#include <bitcoin-build-info.h>
    +#include <bitcoin-build-info.h> // IWYU pragma: keep
     // The <bitcoin-build-info.h>, which is generated by the build environment (cmake/script/GenerateBuildInfo.cmake),
     // could contain only one line of the following:
     //   - "#define BUILD_GIT_TAG ...", if the top commit is tagged
    

    ---

    

    sedited commented at 10:54 AM on September 14, 2026:

    I see, can you open this to master and I'll backport it here?

    ---

    

    hebasto commented at 10:57 AM on September 14, 2026:

    I see, can you open this to master and I'll backport it here?

    On it.

    ---

    

    hebasto commented at 11:06 AM on September 14, 2026:

    I see, can you open this to master and I'll backport it here?

    #36247.

    ---

    

    sedited commented at 11:35 AM on September 14, 2026:

    Backported.

13. fanquake referenced this in commit adca0a9740 on Sep 14, 2026
14. iwyu: Always keep `bitcoin-build-info.h` header

    Macros from the `bitcoin-build-info.h` header may not be used in
    `src/clientversion.cpp` depending on the `CLIENT_VERSION_IS_RELEASE`
    macro value.
    
    Therefore, enforce IWYU to always keep the header.
    
    Github-Pull: bitcoin/bitcoin#36247
    Rebased-From: 1aa500b6b7d8a4dc1ff374f4a033799194bc5470

    e48ac92257
15. hebasto approved
16. 
    hebasto commented at 11:36 AM on September 14, 2026: member

    ACK e48ac922572940a2cb85044c06ddb59128c95188, I have reviewed the code and it looks OK.

17. DrahtBot removed the label CI failed on Sep 14, 2026
18. 
    fanquake commented at 12:51 PM on September 14, 2026: member

    ACK e48ac922572940a2cb85044c06ddb59128c95188

19. fanquake merged this on Sep 14, 2026
20. fanquake closed this on Sep 14, 2026

    ---

21. 
    janb84 commented at 5:47 PM on September 15, 2026: contributor

    I have issue with this commit (and v31.RC1 the tag that is based on this)

    The normal build, builds normally and everything is ok (bitcoind works) With the dev_mode preset; the build succeeds but the execution of bitcoind fails

    ./build_dev_mode/bin/bitcoind --version
    Abort trap: 6              ./build_dev_mode/bin/bitcoind --version
    

    Tested this with both the RC tag and this commit.

    MacOS 27, Aarch64

22. 
    sedited commented at 7:33 AM on September 16, 2026: contributor

    Tested this with both the RC tag and this commit.

    Can you provide a stacktrace or a systrace or something else that might give a bit more insight into what is going on?

23. 
    fanquake commented at 9:18 AM on September 16, 2026: member

    but the execution of bitcoind fails

    I haven't yet been able to recreate this.

Contributors

seditedDrahtBotfanquakehebastojanb84

Milestone
32.0