Macros from the bitcoin-build-info.h header may not be used in src/clientversion.cpp depending on the CLIENT_VERSION_IS_RELEASE macro value.
Therefore, enforce IWYU to always keep the header.
iwyu: Always keep `bitcoin-build-info.h` header #36247
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:260914-keep-build-info changing 1 files +1 −1-
hebasto commented at 11:06 AM on September 14, 2026: member
-
1aa500b6b7
iwyu: Always keep `bitcoin-build-info.h` header
Macros from the `bitcoin-build-info.h` header may not be used in `src/clientversion.cpp` depending on the `CLIENT_VERSION_IS_RELEASE` macro value. Therefore, enforce IWYU to always keep the header.
-
DrahtBot commented at 11:06 AM on September 14, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36247.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process.
Type Reviewers ACK fanquake If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- hebasto added the label Needs Backport (32.x) on Sep 14, 2026
-
fanquake commented at 11:13 AM on September 14, 2026: member
ACK 1aa500b6b7d8a4dc1ff374f4a033799194bc5470
- fanquake merged this on Sep 14, 2026
- fanquake closed this on Sep 14, 2026
- hebasto deleted the branch on Sep 14, 2026
- sedited referenced this in commit e48ac92257 on Sep 14, 2026
- fanquake removed the label Needs Backport (32.x) on Sep 14, 2026
