[32.x] More Backports #36300

pull fanquake wants to merge 9 commits into bitcoin:32.x from fanquake:more_32_0_backports changing 12 files +103 −48
  1. fanquake commented at 3:53 PM on September 19, 2026: member

    Includes:

  2. rpc: Correct OpenRPC default metadata
    Correct six argument metadata entries that produce misleading or invalid
    OpenRPC defaults.
    
    The getdeploymentinfo blockhash fallback and four sighashtype fallbacks
    describe how omitted arguments are resolved. They are not literal values
    accepted by the RPCs, so mark them as DefaultHint values.
    
    The send include_watching option is boolean, but its string default makes
    the generated schema internally inconsistent. Use a boolean value,
    matching the analogous sendall option.
    
    Runtime behavior is unchanged.
    
    Github-Pull: #36297
    Rebased-From: b7f740c594ba1482344a7906b799fb62c533464f
    7a0964a252
  3. fanquake added this to the milestone 32.0 on Sep 19, 2026
  4. DrahtBot added the label Backport on Sep 19, 2026
  5. DrahtBot commented at 3:53 PM on September 19, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36300.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

    LLM Linter (✨ experimental)

    Possible places where named args for integral literals may be used (e.g. func(x, /*named_arg=*/0) in C++, and func(x, named_arg=0) in Python):

    • Parse(descriptor_str, keys, error, true) in src/wallet/walletutil.h

    <sup>2026-09-19 16:30:05</sup>

  6. wallet: Remove WalletDescriptor's default constructor
    Drop the default constructor and add a factory function to construct a
    WalletDescriptor from stream
    
    Github-Pull: #36230
    Rebased-From: 4cc00f7bc04b4c07827728ba5ce1094b338a76a8
    98b9a497e0
  7. wallet: Make WalletDescriptor's descriptor const
    Github-Pull: #36230
    Rebased-From: bb5e8320d76f5175fdf86bdc4c2d24bfc1eed438
    655148d0ac
  8. wallet: Compare descriptors by hash of canonical string
    The canonical string comparison was slow because it would compute the
    canonical string for each comparison. This can be sped up by holding the
    canonical string in memory, computed upon construction of
    WalletDescriptor. To reduce memory usage, this string is further hashed
    so that the comparison operates over the hash of the canonical string.
    
    Github-Pull: #36230
    Rebased-From: 64abb3e8d3610449d541bfff2db23b9ace3fa111
    7fdb8584da
  9. descriptor: Explicitly handle use_apostrophe cases
    Github-Pull: #36230
    Rebased-From: 405b1d6055e78866fe2d86ba6fb16534f9554a32
    81e580401d
  10. descriptor, doc: Clarify miniscript CompatDescriptorHash
    The hardened indicator for Minscript expressions in
    CompatDescriptorHash uses whichever hardened indicator was originally
    given by the user.
    
    Github-Pull: #36230
    Rebased-From: f0f6dce849634e801ac81705176ca8b96abbaa09
    d17455aae8
  11. wallet: Document WalletDescriptor::UpdateFrom
    Github-Pull: #36230
    Rebased-From: f6cbcfd98a000deb17521520074ba46965c410b1
    e6c57c0982
  12. test: Simplify miniscript descriptor check in wallet back compat
    Github-Pull: #36230
    Rebased-From: ebf2f69ee81925057cdcc881e42e861dbdf39ae5
    c46dacf923
  13. test: Add 31.1 to wallet back compat
    Github-Pull: #36230
    Rebased-From: 61edcf92532502e91c2e17b8c2a23b45f5773936
    21a947002e
  14. DrahtBot added the label CI failed on Sep 19, 2026
  15. DrahtBot removed the label CI failed on Sep 19, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-09-20 14:52 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me