Only kernel::Context users selected a hardware SHA256 implementation, so these tools fell back to the generic one. On an M2 Max, grind is ~5x faster and signing 2000 P2PKH inputs with bitcoin-tx ~2.3x.
tools: Call SHA256AutoDetect in bitcoin-util, bitcoin-tx and bitcoin-wallet #36364
pull torkelrogstad wants to merge 1 commits into bitcoin:master from torkelrogstad:2026-09-28-sha256 changing 3 files +6 −0-
torkelrogstad commented at 7:16 AM on September 28, 2026: contributor
-
4048909a53
tools: Call SHA256AutoDetect in bitcoin-util, bitcoin-tx and bitcoin-wallet
Only kernel::Context users selected a hardware SHA256 implementation, so these tools fell back to the generic one. On an M2 Max, grind is ~5x faster and signing 2000 P2PKH inputs with bitcoin-tx ~2.3x.
- DrahtBot added the label Scripts and tools on Sep 28, 2026
-
DrahtBot commented at 7:17 AM on September 28, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/36364.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process.
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #35788 (bitcoin-util: Add evalscript subcommand by ajtowns)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
maflcko commented at 7:55 AM on September 28, 2026: member
lgtm ACK 4048909a53422bf86b207a9b5c8650e8edd25737
-
hebasto commented at 9:28 AM on September 28, 2026: member
Concept ACK.
-
furszy commented at 2:21 PM on September 28, 2026: member
utACK 4048909a53422bf86b207a9b5c8650e8edd25737
- DrahtBot requested review from hebasto on Sep 28, 2026
- fanquake added the label Needs Backport (32.x) on Sep 29, 2026
- fanquake merged this on Sep 29, 2026
- fanquake closed this on Sep 29, 2026
- fanquake removed the label Needs Backport (32.x) on Sep 29, 2026
-
- fanquake referenced this in commit 02a7f11038 on Sep 29, 2026
- hebasto approved
-
hebasto commented at 3:21 PM on September 29, 2026: member
Post-merge ACK 4048909a53422bf86b207a9b5c8650e8edd25737.
Labels