[31.x] net: don't discourage private broadcast peers #36358

pull andrewtoth wants to merge 1 commits into bitcoin:31.x from andrewtoth:private-broadcast-discourage changing 4 files +44 −5

andrewtoth commented at 3:37 PM on September 27, 2026: contributor

Discouraging a private broadcast connection may be observable. Prevent this by keeping private broadcast connections outside normal discouragement handling. Misbehaving private broadcast peers are still disconnected.

Rebase of #36312 onto 31.x branch, since it could not be applied cleanly.

net: don't discourage private broadcast peers

Keep private broadcast connections outside normal discouragement handling.
Misbehaving private broadcast peers are still disconnected.

22ac577566

DrahtBot added the label Backport on Sep 27, 2026
DrahtBot commented at 3:37 PM on September 27, 2026: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



External sites
- Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36358
- Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36358.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36358#author-ralph


Reviews

See the guideline and AI policy for information on the review process.

Type Reviewers

ACK jonatack, vasild, davidgumberg

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.
jonatack commented at 4:34 AM on September 28, 2026: member

Review ACK 22ac577566a0387dcf5e1923e2f7a752d2a51c9a
fanquake added this to the milestone 31.2 on Sep 29, 2026
vasild approved

Type	Reviewers
ACK	jonatack, vasild, davidgumberg

vasild commented at 2:03 PM on October 6, 2026: contributor

ACK 22ac577566a0387dcf5e1923e2f7a752d2a51c9a

git range-diff eab6630add~..eab6630add 22ac577566~..22ac577566

<details> <summary>Show Signature</summary>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

ACK 22ac577566a0387dcf5e1923e2f7a752d2a51c9a

`git range-diff eab6630add~..eab6630add 22ac577566~..22ac577566`
-----BEGIN PGP SIGNATURE-----

iQRPBAEBCAA5FiEE5k2NRWFNsHVF2czBVN8G9ktVy78FAmrE/5YbFIAAAAAABAAO
bWFudTIsMi41KzEuMTIsMiwzAAoJEFTfBvZLVcu/7cgf/i+iINSKzIZxa+9LBlxq
i+SaPzzkOhnUp404xN6aSlCzPUHdYhLnI7hkXWjbTnsSREtZ8xmTehzxJGzNqy3Y
7eWMwC9quALaOM01nvsIqgNAS4WtAe6dAq/pHfN92kp+r/PEiY1ZKM+0EkP5KfJW
c7JI2iMLxurgzU1YEANmXhtbVamNNadQ5uDztI/z4FNqw8ean10BMUUnQJ/J6t7g
MRiTl2ETG2kxq02AUWWzw4dSV7UlRHrRDRI6uPwdyDxvrl67kArxG+NuSbfNVXzM
p4A60IeloIQFofzOEacN5KTQhdp5pp0Tp7X0NfD64ETMfERqTrAmmufdlmKpnumv
ZmsFCrDmXtcyADeLw2W1YlH1wgUDeprriKDQOvmAz2EzYQGxIFTMsaITKJBcUVSY
GmIwsuZiNcI/2+VUfnB5pYI0opbVVAIb1MxTaBHbZZlYNFSes8fws9MnQinKgN2E
IIxdw4AwJw79qqsuC6Hco4dCw3MZ9DtS21uP5vRyNF1HYzSPkqFw3uBJ+UXltrAv
HvF92daklLawve7WmcV1A38P1WBb5K9p3+qcjjahKdt1F2g/WU0BjnhQZI/k17nD
erebcv3LOgYC1e0YsFdS9OhzF2xBv57NS//GhhnUlVEWgZmxJ3TzGCeSKIJZ0Ka+
ycd8L93dRqZ058hcZ9LOTHr4QlEEC2s8yAdznznckx5htYu4wK/YydM01Vl1IgL9
oLbfPNIycKsIotammZZtKYZrdNpy7ILHTZOzKuYDKR4QsQNMNb3mjA+W0lT1V7mn
g5rQWvE/2QJJzpfttQRsaaHy0yyyDairmGo6Fa3cO5yscZYUy89l6wquvLFdse0L
QjCnOmHOG9dy37Q5ZYdO4ncCAjOb3bUegjJ/JR7YqnythOGqKu2kp2qacCbEnSjA
dmygRz4GcsjML30mIH7I3w2iudbnEbPJFqweWwJJ+MHL1waN+QOwOxOofOmqGjlx
fOkG3qrP4cylL22kEZ0MZROW6o8zVm3W9kttUvWe+uYxJ1EG7J6JyOKtQdspbtkM
oQq04J3yFq3r71Jiy8Ws1DDFQSqpxVsLU9qyqa9zKzRSrJMmCFR8v9srgLHCdJP2
Hn9TKWqgrYtdnnv2k0JRMcMAGn00OjWBJoony5/4CD0gl7tOriqlH1j5z7WZTZ5l
Bta+dxzNUogbQsx9+RFrW42kKy+RSuRqWAbAscqLe6g+yKc8fd6Glmseiw0qot6N
mQIeuwx8CEZqPTZOYyW0C/TCUsRdBjuxO0Xh16tiHBh1mVnBYvrQHPiUXXH6woRs
o1jefPfKkhuo3oBY3LDCIf4Afs/IRdVLNlBlEgnWXQXyvS/BhzWRzU/KXkEy2IMT
/uA=
=hvbh
-----END PGP SIGNATURE-----

vasild's public key is on openpgp.org

</details>

davidgumberg commented at 12:47 AM on October 9, 2026: contributor

ACK https://github.com/bitcoin/bitcoin/commit/22ac577566a0387dcf5e1923e2f7a752d2a51c9a

Contributors

Labels

Milestone
31.2

Linked (view graph)

#36312 net: don't discourage private broadcast peers

[31.x] net: don't discourage private broadcast peers #36358

External sites

Reviews