refactor: fix mismatched and undefined declarations #36744

pull fanquake wants to merge 5 commits into bitcoin:master from fanquake:rawtx_addinputs_static changing 7 files +4 −14

fanquake commented at 1:12 PM on November 3, 2026: member

Remove or fix function declarations that don't match any definition.

Split out of #36743. Ideally we can have the compiler enforce/flag this in future.

rpc: make AddInputs static, remove mismatched declaration

The header declared AddInputs(..., bool rbf), which was never defined,
while the definition takes std::optional<bool> and has no declaration.

410843a684

DrahtBot added the label Refactoring on Nov 3, 2026
DrahtBot commented at 1:12 PM on November 3, 2026: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



External sites
- Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36744
- Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36744.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36744#author-ralph


Reviews

See the guideline and AI policy for information on the review process. A summary of reviews will appear here.
common: make FeeModeInfo static, remove mismatched declaration 3fa42941d1
rpc: remove undefined RPCResult::ToStringObj and ToDescriptionString
These were declared in fa6b061fc1 but never defined or used.
0ae6589244

qt: remove undefined BanTableModel::{start,stop}AutoRefresh

The definitions were removed in 43c1f5b8d7, but the declarations were
left behind.

bad11ff68e

http: use MockableSteadyClock::time_point in ShouldDisconnect declaration
Match the definition, and the m_idle_since member.
5f972485ff
fanquake force-pushed on Nov 3, 2026
DrahtBot added the label CI failed on Nov 3, 2026
DrahtBot removed the label CI failed on Nov 3, 2026

Contributors

Labels