test: fix waitTipChanged timeout on slow hosts and use monotonic clock in interface_ipc_mining #36791

pull ViniciusCestarii wants to merge 2 commits into bitcoin:master from ViniciusCestarii:fix-flaky-interface-ipc-mining changing 1 files +6 −6
  1. ViniciusCestarii commented at 3:25 PM on November 6, 2026: contributor

    Follow up suggested in #36731 (comment).

    The first commit fix the timeout on a slow host and the second one use time.monotonic() for durations.

    Command to reproduce the errors with a simulated slow wall clock:

    faketime --exclude-monotonic -f "+0 x0.1" build/test/functional/interface_ipc_mining.py
    
  2. test: fix waitTipChanged timeout on slow hosts in interface_ipc_mining 9b6dadb39c
  3. test: use time.monotonic() for durations in interface_ipc_mining 46ee95db49
  4. DrahtBot added the label Tests on Nov 6, 2026
  5. DrahtBot commented at 3:25 PM on November 6, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK nervana21

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  6. maflcko commented at 3:40 PM on November 6, 2026: member

    Command to reproduce slow host:

    I think this is a "fast host", as the test takes a shorter "wall" time?

  7. nervana21 commented at 7:10 PM on November 6, 2026: contributor

    Concept ACK

  8. ViniciusCestarii commented at 10:52 PM on November 6, 2026: contributor

    I think this is a "fast host", as the test takes a shorter "wall" time?

    You are right. It can be confusing lol. The first commit fixes a wait that takes too long (this is what confused me) and the second fixes durations measured with a wall clock that doesn't match real time. Renamed it to "slow wall clock".

  9. nervana21 commented at 3:03 AM on November 8, 2026: contributor

    tACK 46ee95db49c9fa7f4b80a1e59816660f5ee0c4f4


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-10 20:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me