test: use long timeout for event waits in interface_ipc_mining #36862

pull ViniciusCestarii wants to merge 1 commits into bitcoin:master from ViniciusCestarii:ipc-mining-long-timeout changing 1 files +8 −5
  1. ViniciusCestarii commented at 6:44 PM on November 13, 2026: contributor

    Follow-up to #36791, #36791 (review) by ryanofsky.

    #36791 fixed the waitTipChanged timeout on slow hosts, but the template6 waitNext call has the same race: it waits for an event the test triggers after a 0.1s sleep, with a 1s timeout.

    This adds long_ipc_timeout and uses it for all waits that end on an event the test triggers.

    To reproduce failure on master:

    diff --git a/test/functional/interface_ipc_mining.py b/test/functional/interface_ipc_mining.py
    index cdef196fd0..49e1c8a9c1 100755
    --- a/test/functional/interface_ipc_mining.py
    +++ b/test/functional/interface_ipc_mining.py
    @@ -320,7 +320,8 @@ class IPCMiningTest(BitcoinTestFramework):
                     self.log.debug("Wait for another, get one after increase in fees in the mempool")
                     template6 = await wait_and_do(
                         mining_wait_next_template(template5, stack, ctx, waitoptions),
    -                    lambda: self.miniwallet.send_self_transfer(fee_rate=10, from_node=self.nodes[0]))
    +                    lambda: self.miniwallet.send_self_transfer(fee_rate=10, from_node=self.nodes[0]),
    +                    sleep_time=1.2)
                     assert template6 is not None
                     block4 = await mining_get_block(template6, ctx)
                     assert_equal(len(block4.vtx), 3)
    
    
  2. test: use long timeout for event waits in interface_ipc_mining
    Waits that return on an event the test triggers could time out on slow
    hosts with the 1s default. Use a long timeout for all of them.
    74135e2e62
  3. DrahtBot added the label Tests on Nov 13, 2026
  4. DrahtBot commented at 6:44 PM on November 13, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK ryanofsky, nervana21, w0xlt

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. nervana21 commented at 6:55 PM on November 13, 2026: contributor

    Concept ACK

  6. ryanofsky approved
  7. ryanofsky commented at 8:44 PM on November 13, 2026: contributor

    Tested ACK 74135e2e625030b18daf7539bd19dabb75948af1. This finishes the fix from #36791: every wait that returns on an event the test triggers now has at least a minute, so none of them can time out on a slow host with the default timeout factor. I checked that the test passes normally, with the faketime command from #36791, and with sleep_time=1.2 on the template6 wait, which failed before.

    The waits still using default_ipc_timeout (template4, template5 and the two waitNext policy tests) are fine as they are: the fees they wait for are already in the mempool, and waitNext always checks fees once after its first one-second tick, however short the timeout.

  8. nervana21 commented at 2:06 AM on November 14, 2026: contributor

    tACK 74135e2e625030b18daf7539bd19dabb75948af1

  9. w0xlt commented at 6:36 AM on November 14, 2026: contributor

    ACK 74135e2e625030b18daf7539bd19dabb75948af1

  10. fanquake merged this on Nov 16, 2026
  11. fanquake closed this on Nov 16, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-18 16:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me