ipc: remove pre-v14 libmultiprocess compat definitions #36817

1. 
   fanquake commented at 4:51 PM on November 9, 2026: member

   No description provided.

2. DrahtBot added the label IPC on Nov 9, 2026
3. 
   DrahtBot commented at 4:51 PM on November 9, 2026: contributor

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--006a51241073e994b41acfe9ec718e94-->

   External sites

   • Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36817
   • Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36817.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36817#author-ralph

   <!--021abf342d371248e50ceaed478a90ca-->

   Reviews

   See the guideline and AI policy for information on the review process.

   Type	Reviewers
   ACK	ryanofsky

   If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #36074 _{<img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/36074.svg">} (scripted-diff: [test] Add util/check.h includes for assertions by maflcko)
   • #35916 _{<img src="https://drahtbot.space/ack_count/bitcoin/bitcoin/35916.svg">} (fuzz: improve ipc fuzz coverage by enirox001)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

   <!--5faf32d7da4f0f540f40219e4f7537a3-->

4. 
   fanquake commented at 5:11 PM on November 9, 2026: member

   cc @ryanofsky

5. DrahtBot added the label CI failed on Nov 9, 2026
6. DrahtBot removed the label CI failed on Nov 9, 2026
7. fanquake force-pushed on Nov 10, 2026
8. fanquake requested review from Sjors on Nov 10, 2026
9. fanquake force-pushed on Nov 10, 2026
10. DrahtBot added the label CI failed on Nov 10, 2026
11. in src/ipc/util.h:24 in 7728c739f0 outdated

      19 | -
      20 | -namespace mp {
      21 | -// Definitions that can be deleted when libmultiprocess subtree is updated to
      22 | -// v14. Having these allows Bitcoin Core changes to be decoupled from
      23 | -// libmultiprocess changes so they don't have to be reviewed in a single PR.
      24 | -#if MP_MAJOR_VERSION < 14
    

    ---

    ---

    

    ryanofsky commented at 12:58 PM on November 10, 2026:

    In commit "ipc: remove pre-v14 libmultiprocess compat definitions" (7728c739f0da3ed5fde6e1fe9e33ae95b4af3ebe)

    Would be good to bump the documented minimum in doc/dependencies.md with this change. Something like:

    -| [libmultiprocess](../depends/packages/native_libmultiprocess.mk) ([IPC](multiprocess.md)) | [link](https://github.com/bitcoin-core/libmultiprocess/tags) | [v7.0-pre1](https://github.com/bitcoin/bitcoin/pull/33517) |
    +| [libmultiprocess](../depends/packages/native_libmultiprocess.mk) ([IPC](multiprocess.md)) | [link](https://github.com/bitcoin-core/libmultiprocess/tags) | [v14.0](https://github.com/bitcoin/bitcoin/pull/36817) |
    

    ---

    

    fanquake commented at 2:11 PM on November 10, 2026:

    Sure, added.

12. ryanofsky approved
13. 
    ryanofsky commented at 1:04 PM on November 10, 2026: contributor

    Code review ACK 7728c739f0da3ed5fde6e1fe9e33ae95b4af3ebe. Thanks for the cleanup!

14. DrahtBot removed the label CI failed on Nov 10, 2026
15. ipc: remove pre-v14 libmultiprocess compat definitions ba9c60a61d
16. fanquake force-pushed on Nov 10, 2026
17. ryanofsky approved
18. 
    ryanofsky commented at 2:46 PM on November 10, 2026: contributor

    Code review ACK ba9c60a61da5dceb5d5e7cd0a45b6ff3e85c94b1. Just adds requested documentation update since last review. Thanks!

19. fanquake merged this on Nov 10, 2026
20. fanquake closed this on Nov 10, 2026

    ---

21. fanquake deleted the branch on Nov 10, 2026

Contributors

fanquakeDrahtBotryanofsky

Review Requested
Sjors