Since #32618, getaddressinfo returns iswatchonly: false for every address. It was kept and marked "(DEPRECATED)" so it could be removed later without surprising users (review comment), but it was never put behind -deprecatedrpc. The v30 release notes also say it was already removed from all RPCs, which isn't true for getaddressinfo.
This returns it only with -deprecatedrpc=iswatchonly, like startingheight in getpeerinfo (#34197), so it can be removed in the next release.
Since watch-only was removed from the wallet in #32618, iswatchonly is
always false. It was kept and marked "(DEPRECATED)" in the help so that
it could be removed later without surprising users, but it was never
put behind -deprecatedrpc, although the v30 release notes say it was
removed from all RPCs.
Return it only with -deprecatedrpc=iswatchonly, as was done for the
startingheight field of getpeerinfo, so it can be removed in the next
release.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline and AI policy for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | jonatack |
If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--174a7506f384e20aa4161008e828411d-->
Reviewers, this pull request conflicts with the following ones:
encryptwallet RPC for encrypting existing wallets. by davidgumberg)If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
0 | @@ -0,0 +1,7 @@ 1 | +Updated RPCs 2 | +------------ 3 | + 4 | +- The `getaddressinfo` RPC no longer returns the `iswatchonly` field unless 5 | + the configuration option `-deprecatedrpc=iswatchonly` is used. The field has 6 | + always been `false` since v30 and will be fully removed in the next major 7 | + release. (#36864)
Possibly helpful for users to add something like:
(Use the private_keys_enabled field of RPC getwalletinfo to know if a wallet is watch-only.)
0 | @@ -0,0 +1,7 @@ 1 | +Updated RPCs 2 | +------------ 3 | + 4 | +- The `getaddressinfo` RPC no longer returns the `iswatchonly` field unless
nit
- RPC `getaddressinfo` no longer returns the `iswatchonly` field, unless
0 | @@ -0,0 +1,7 @@ 1 | +Updated RPCs 2 | +------------ 3 | + 4 | +- The `getaddressinfo` RPC no longer returns the `iswatchonly` field unless 5 | + the configuration option `-deprecatedrpc=iswatchonly` is used. The field has 6 | + always been `false` since v30 and will be fully removed in the next major
nit
always returned `false` since [#32618](/bitcoin-bitcoin/32618/) in v30 and will be fully removed in the next major
ACK 5b2f979c9e474a641b90902c3a87dee93c8f2899
Feel free to ignore the nits.