[31.x] Backports #36901

pull fanquake wants to merge 5 commits into bitcoin:31.x from fanquake:more_31_x_backports changing 8 files +21 −57
  1. fanquake commented at 4:13 PM on November 17, 2026: member

    Backports:

  2. memusage: Make fields of STL helper structs public
    The `stl_tree_node`, `list_node` and `unordered_node` class templates
    only mimic the layout of the standard library's container nodes, so
    that `sizeof` yields an estimate of the memory they use. Their fields
    are never accessed.
    
    Since llvm/llvm-project#237374, Clang 24 diagnoses these fields with
    `-Wunused-private-field`.
    
    This change drops the `private:` access specifiers. It does not affect
    the size or alignment of the structs, as all their fields keep the same
    access control, and it is consistent with `stl_shared_counter`.
    
    Github-Pull: #36869
    Rebased-From: b9a6b0ca51801e95956b7d5307d5b198b9fb7d3f
    72d6048d5f
  3. fanquake added this to the milestone 31.4 on Nov 17, 2026
  4. DrahtBot added the label Backport on Nov 17, 2026
  5. DrahtBot commented at 4:14 PM on November 17, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK instagibbs

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  6. DrahtBot added the label CI failed on Nov 17, 2026
  7. DrahtBot removed the label CI failed on Nov 17, 2026
  8. cmake: Switch `include_directories` -> `target_include_directories`
    Use of non-target directives is not recommended. As of CMake 4.5.0, it
    triggers `-Wnon-target-directive` warnings.
    
    Github-Pull: #36889
    Rebased-From: 460f877fac200ccfde265d12613b352def903cf0
    c4547c490f
  9. cmake: Remove `WarnAboutGlobalProperties` module
    The module is superseded by CMake's `-Wnon-target-directive` warnings,
    which are enabled when using the "dev-mode" preset.
    
    Github-Pull: #36889
    Rebased-From: 435d5b227748a0ac5d6d2887050acf02304576f2
    1a385857e1
  10. fanquake force-pushed on Nov 18, 2026
  11. fanquake requested review from willcl-ark on Nov 18, 2026
  12. fanquake requested review from instagibbs on Nov 18, 2026
  13. fanquake marked this as ready for review on Nov 18, 2026
  14. net_processing: set fDisconnect instead of calling DisconnectNode
    MaybeDiscourageAndDisconnect calls DisconnectNode which creates a
    CSubNet containing only the CNode's address. This will disconnect
    every CNode with the same IP address. This is normally not a problem,
    except for clearnet-over-tor. If a node has an honest clearnet-over-tor
    inbound connection, the IP of the inbound peer will be the exit node's
    IP address. If an attacker connects to the node through the same exit
    node and sends an invalid message, they can cause every inbound peer
    sharing the exit node's IP to get disconnect. Fix this by only
    disconnecting the misbehaving CNode rather than every CNode sharing
    the IP.
    
    Github-Pull: #36894
    Rebased-From: d63068c58ec9fcc94876bce30865d1a7266d64d4
    35f34a31a6
  15. doc: update release notes for v31.x 1fed2147b6
  16. fanquake force-pushed on Nov 18, 2026
  17. DrahtBot added the label CI failed on Nov 18, 2026
  18. Crypt-iQ commented at 6:58 PM on November 18, 2026: contributor

    Checked that 35f34a31a6cf657d9d0cbb058327f0b37e4f191e specifically is correct

  19. DrahtBot removed the label CI failed on Nov 18, 2026
  20. fanquake merged this on Nov 19, 2026
  21. fanquake closed this on Nov 19, 2026

  22. fanquake deleted the branch on Nov 19, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-19 19:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me