hebasto
commented at 2:00 PM on November 16, 2026:
member
Use of non-target directives is not recommended. As of CMake 4.5.0, such use triggers -Wnon-target-directive warnings:
$ cmake -B build -Wnon-target-directive
<snip>
CMake Warning (non-target-directive) at src/CMakeLists.txt:8 (include_directories):
Use of non-target directives is not recommended. Consider
target_include_directories instead.
This warning is for project developers. Use -Wno-author or
-Wno-non-target-directive to suppress it.
<snip>
This PR:
Links bitcoin_ipc against core_interface, so that ipc/stub.cpp is compiled with the project-wide build flags.
Replaces the include_directories() call in src/CMakeLists.txt with target_include_directories().
Use of non-target directives is not recommended. As of CMake 4.5.0, it
triggers `-Wnon-target-directive` warnings.
460f877fac
hebasto force-pushed on Nov 16, 2026
DrahtBot added the label CI failed on Nov 16, 2026
hebasto marked this as ready for review on Nov 16, 2026
DrahtBot removed the label CI failed on Nov 16, 2026
fanquake
commented at 10:41 AM on November 17, 2026:
member
Our custom check does not cover the src/ subdirectory.
Can you elaborate? Does this mean it wasn't working properly?
Once one of the CI jobs runs CMake >=4.5.0, that custom check can be removed.
brew is already shipping CMake 4.5.0, so it should be in the CI any time from now, and I'd assume most macOS devs are already using it. So this could just be dropped now?
fanquake added this to the milestone 33.0 on Nov 17, 2026
fanquake added the label Needs backport (30.x) on Nov 17, 2026
fanquake added the label Needs Backport (31.x) on Nov 17, 2026
fanquake added the label Needs Backport (32.x) on Nov 17, 2026
hebasto
commented at 11:19 AM on November 17, 2026:
member
Our custom check does not cover the src/ subdirectory.
Can you elaborate? Does this mean it wasn't working properly?
It checks the properties of the current directory, which is the repo’s root. If I recall correctly, that was considered sufficient when the check was introduced, as all global compiler and linker flags are set there. The include_directories() call fixed in this PR is the only case it missed.
cmake: Remove `WarnAboutGlobalProperties` module
The module is superseded by CMake's `-Wnon-target-directive` warnings,
which are enabled when using the "dev-mode" preset.
435d5b2277
hebasto
commented at 11:35 AM on November 17, 2026:
member
Once one of the CI jobs runs CMake >=4.5.0, that custom check can be removed.
brew is already shipping CMake 4.5.0, so it should be in the CI any time from now, and I'd assume most macOS devs are already using it. So this could just be dropped now?
Sure. Dropped.
fanquake
commented at 3:51 PM on November 18, 2026:
member
ACK435d5b227748a0ac5d6d2887050acf02304576f2 - going to merge this now, given it was mentioned on IRC that devs are seeing local build breakage (after updating CMake).
fanquake merged this on Nov 18, 2026
fanquake closed this on Nov 18, 2026
hebasto deleted the branch on Nov 18, 2026
fanquake
commented at 4:07 PM on November 18, 2026:
member
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2026-11-19 19:51 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me