Backports:
[30.x] More Backports #36902
pull fanquake wants to merge 4 commits into bitcoin:30.x from fanquake:more_30_x_backports changing 5 files +12 −56-
fanquake commented at 4:24 PM on November 17, 2026: member
-
2030dbcb6c
memusage: Make fields of STL helper structs public
The `stl_tree_node`, `list_node` and `unordered_node` class templates only mimic the layout of the standard library's container nodes, so that `sizeof` yields an estimate of the memory they use. Their fields are never accessed. Since llvm/llvm-project#237374, Clang 24 diagnoses these fields with `-Wunused-private-field`. This change drops the `private:` access specifiers. It does not affect the size or alignment of the structs, as all their fields keep the same access control, and it is consistent with `stl_shared_counter`. Github-Pull: #36869 Rebased-From: b9a6b0ca51801e95956b7d5307d5b198b9fb7d3f
- fanquake added this to the milestone 30.6 on Nov 17, 2026
- DrahtBot added the label Backport on Nov 17, 2026
-
DrahtBot commented at 4:25 PM on November 17, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
External sites
- Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36902
- Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36902.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36902#author-ralph
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process.
Type Reviewers ACK instagibbs If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
6c55420edb
cmake: Switch `include_directories` -> `target_include_directories`
Use of non-target directives is not recommended. As of CMake 4.5.0, it triggers `-Wnon-target-directive` warnings. Github-Pull: #36889 Rebased-From: 460f877fac200ccfde265d12613b352def903cf0
-
bf137ff02a
cmake: Remove `WarnAboutGlobalProperties` module
The module is superseded by CMake's `-Wnon-target-directive` warnings, which are enabled when using the "dev-mode" preset. Github-Pull: #36889 Rebased-From: 435d5b227748a0ac5d6d2887050acf02304576f2
-
doc: update release notes for v30.x 71858c7699
- fanquake force-pushed on Nov 18, 2026
- fanquake marked this as ready for review on Nov 18, 2026
- fanquake requested review from willcl-ark on Nov 19, 2026
-
instagibbs commented at 2:19 PM on November 19, 2026: member
- fanquake merged this on Nov 19, 2026
- fanquake closed this on Nov 19, 2026
- fanquake deleted the branch on Nov 19, 2026