- Use generateblock with submit=False to create header, and avoid manual disconnect+reconnect
- Drop hard-coded magic
3
test: simplify wallet_basic and rpc_getblockfilter tests #36914
pull maflcko wants to merge 2 commits into bitcoin:master from maflcko:2611-test-cleanups changing 2 files +6 −11-
maflcko commented at 12:32 PM on November 19, 2026: member
-
fa06fd5a69
test: Use generateblock with submit=False to create header
This is shorter than manual disconnect+reconnect
-
1eeeee497e
test: Drop hard-coded magic 3
Now that there are 3 nodes, use self.nodes directly.
- DrahtBot added the label Tests on Nov 19, 2026
-
DrahtBot commented at 12:32 PM on November 19, 2026: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
External sites
- Code coverage & benchmarks: https://corecheck.dev/bitcoin/bitcoin/pulls/36914
- Ralph review <img src=https://review.fish.foo/assets/bitcoin/bitcoin/36914.png alt="Ralph review status"> https://git.fish.foo/bitcoin/bitcoin/pulls/36914#author-ralph
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline and AI policy for information on the review process.
Type Reviewers ACK ViniciusCestarii If your review is incorrectly listed, please copy-paste <code><!--meta-tag:bot-skip--></code> into the comment that the bot should ignore.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- DrahtBot added the label CI failed on Nov 19, 2026
-
maflcko commented at 1:25 PM on November 19, 2026: member
The three CI failures are unrelated and can be ignored.
-
ViniciusCestarii commented at 4:34 PM on November 19, 2026: contributor
ACK 1eeeee497e04ce3ef5ca2da5f2a6985913b61068
- fanquake merged this on Nov 19, 2026
- fanquake closed this on Nov 19, 2026
-
w0xlt commented at 6:23 PM on November 19, 2026: contributor
Post-Merge ACK