test: simplify wallet_basic and rpc_getblockfilter tests #36914

pull maflcko wants to merge 2 commits into bitcoin:master from maflcko:2611-test-cleanups changing 2 files +6 −11
  1. maflcko commented at 12:32 PM on November 19, 2026: member
    • Use generateblock with submit=False to create header, and avoid manual disconnect+reconnect
    • Drop hard-coded magic 3
  2. test: Use generateblock with submit=False to create header
    This is shorter than manual disconnect+reconnect
    fa06fd5a69
  3. test: Drop hard-coded magic 3
    Now that there are 3 nodes, use self.nodes directly.
    1eeeee497e
  4. DrahtBot added the label Tests on Nov 19, 2026
  5. DrahtBot commented at 12:32 PM on November 19, 2026: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    External sites

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK ViniciusCestarii

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  6. DrahtBot added the label CI failed on Nov 19, 2026
  7. maflcko commented at 1:25 PM on November 19, 2026: member

    The three CI failures are unrelated and can be ignored.

  8. fanquake commented at 1:47 PM on November 19, 2026: member

    cc @w0xlt

  9. ViniciusCestarii commented at 4:34 PM on November 19, 2026: contributor

    ACK 1eeeee497e04ce3ef5ca2da5f2a6985913b61068

  10. fanquake merged this on Nov 19, 2026
  11. fanquake closed this on Nov 19, 2026

  12. w0xlt commented at 6:23 PM on November 19, 2026: contributor

    Post-Merge ACK


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-19 19:51 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me