Report minimum ping time in getpeerinfo #6633

pull TheBlueMatt wants to merge 1 commits into bitcoin:master from TheBlueMatt:minpingreport changing 3 files +4 −0

TheBlueMatt commented at 8:11 PM on September 3, 2015: member

No description provided.
Report minimum ping time in getpeerinfo a6eb4ba38b
jonasschnelli commented at 7:02 AM on September 4, 2015: contributor

utACK
paveljanik commented at 9:09 AM on September 4, 2015: contributor

ACK
fanquake commented at 9:11 AM on September 4, 2015: member

utACK

On Friday, September 4, 2015, paveljanik notifications@github.com wrote:

ACK

— Reply to this email directly or view it on GitHub #6633 (comment).

MarcoFalke commented at 11:39 AM on September 4, 2015: member

minping seems to be zero in most cases. Being connected to 3 "incoming peers" on localhost and 8 "outgoing peers" on testnet I get

$ getpeerinfo|grep minping
    "minping": 0,
    "minping": 0,
    "minping": 0,
    "minping": 0.107754,
    "minping": 0,
    "minping": 0,
    "minping": 0,
    "minping": 0,
    "minping": 0.219713,
    "minping": 9.6e-05,
    "minping": 0,

laanwj commented at 1:30 PM on September 4, 2015: member

@MarcoFalke Good catch: nMinPingUsecTime is left uninitialized on CNode creation. And as it is a moving minimum, it should probably default to std::numeric_limits<int64_t>::max() initially, not zero.
laanwj commented at 1:31 PM on September 4, 2015: member

ACK on this pull.
laanwj merged this on Sep 4, 2015
laanwj closed this on Sep 4, 2015
laanwj referenced this in commit bbc2b39860 on Sep 4, 2015
MarcoFalke locked this on Sep 8, 2021

Contributors