mempoolminfee returns incorrect data before the dynamic mempool limit has changed #6941

"mempoolminfee": 0.00000000

When the minrelaytxfee is > 0.

This is expected (the mempool's min fee is 0), though maybe we could change it to just minfee and use max of the two...

On November 4, 2015 11:48:46 AM PST, Gregory Maxwell notifications@github.com wrote:

"mempoolminfee": 0.00000000

When the minrelaytxfee is > 0.

---

Reply to this email directly or view it on GitHub: #6941

This is confusing, since the effective min feerate is not zero, it's the minrelayfee. perhaps if there were just another field to show the other data.

The fact there there is a "mempool minrelay fee" different from the conceptual minimum relay fee is an implementation detail; no need to expose it through RPC.

@sipa ACK, it should be one unified field, not two.

On November 4, 2015 3:07:08 PM PST, Pieter Wuille notifications@github.com wrote:

The fact there there is a "mempool minrelay fee" different from the conceptual minimum relay fee is an implementation detail; no need to expose it through RPC.

---

Reply to this email directly or view it on GitHub: #6941 (comment)

no need to expose it through RPC

At least mention it in help getmempoolinfo... ... Another reason to clean up the rpc "hard coded white space mess".

@sipa for now they are different in whether or not priority (free) txs are allowed.

An attempt to document this was done in #7118.

Anything left to do here?

#7118 adds the following documentation;

"mempoolminfee": xxxxx (numeric) Minimum fee for tx to be accepted\n"

I don't think that's particularly helpful in distinguishing mempool versus relaying minimum.

The fact there there is a "mempool minrelay fee" different from the conceptual minimum relay fee is an implementation detail; no need to expose it through RPC.

Not sure about this - getmempoolinfo returns info about the mempool. Relaying is an another concern - we split off the different RPC info calls for good reason. Not sure whether they should be muddled together, unless we logically make minrelaytxfee part of the mempool logic.

@laanwj the relay and mempool logic are completely intertwined and both numbers affect both. I actually don't think we should change anything right now (other than potentially better documentation)

I think its useful to be aware of both numbers. The minrelaytxfee is a fixed number, but txs can get in below that subject to free rate limiting. The mempoolminfee is a floating number below which txs can not get in period. Even if we eliminate free transactions entirely, it could be useful to know the minrelaytxfee separately from the current mempoolminfee.

Yes, makes sense to add minrelaytxfee to the same RPC then, then put that explanation in the RPC help.

Has there been any progress in adding minrelaytxfee to getmempoolinfo RPC?

@jonathancross Not yet. Pull request welcome :)

Any reason to keep this issue open only for the doc changes when calling help getmempoolinfo? I'd be happy to make the doc changes in another PR (once #11475 is merged), but can they be simply be made in #11475?