Previously fundrawtransaction w/ includeWatching set to false was treated as thought it was set to true.
Also better error message for empty output case.
Fix fundrawtransaction handling of includeWatching #7010
pull petertodd wants to merge 2 commits into bitcoin:master from petertodd:2015-11-fix-fundrawtransaction-bugs changing 1 files +4 −1-
petertodd commented at 8:55 PM on November 13, 2015: contributor
-
61e1eb2e1c
Actually use includeWatching value in fundrawtransaction
Previously if you called fundrawtransaction and set includeWatching to false it'd act as through you set it to true.
-
10953a7d32
Better error message for fundrawtransaction w/ empty vout
Previously this case failed deep in Cwallet::CreateTransaction() with the error message "Transaction amounts must be positive"
-
kanzure commented at 9:05 PM on November 13, 2015: contributor
ACK.
-
TheBlueMatt commented at 9:06 PM on November 13, 2015: member
ACK
-
btcdrak commented at 4:56 AM on November 14, 2015: contributor
ACK
-
gmaxwell commented at 5:17 AM on November 14, 2015: contributor
ACK.
- gmaxwell merged this on Nov 14, 2015
- gmaxwell closed this on Nov 14, 2015
- gmaxwell referenced this in commit e0a5ef8427 on Nov 14, 2015
- luke-jr referenced this in commit 2b4108c033 on Nov 27, 2015
- DrahtBot locked this on Sep 8, 2021
Contributors