This fixes some benign races reported by helgrind. It makes some things atomic that need it, and fixes locking in addrman so that some log statements cant print garbage.
Fix some benign races #9225
pull TheBlueMatt wants to merge 5 commits into bitcoin:master from TheBlueMatt:2016-11-lockfixes changing 5 files +32 −36-
TheBlueMatt commented at 11:45 PM on November 26, 2016: member
-
Make fDisconnect an std::atomic 42071ca264
-
Make fImporting an std::atomic 047ea1052d
-
Fix AddrMan locking dbfaade72a
-
Remove double brackets in addrman 303352286f
-
Fix unlocked access to vNodes.size() dfed983f19
- MarcoFalke added the label Refactoring on Nov 27, 2016
-
morcos commented at 2:20 AM on November 27, 2016: member
Thanks! The fDisconnect race was bothering me.
utACK
-
gmaxwell commented at 10:28 AM on November 29, 2016: contributor
utACK. All looks good to me.
-
laanwj commented at 11:39 AM on November 29, 2016: member
utACK dfed983
- laanwj merged this on Nov 29, 2016
- laanwj closed this on Nov 29, 2016
- laanwj referenced this in commit 5488514b90 on Nov 29, 2016
- codablock referenced this in commit a3da08090b on Jan 16, 2018
- codablock referenced this in commit 0caef236f5 on Jan 16, 2018
- codablock referenced this in commit ab9bce2c3a on Jan 17, 2018
- andvgal referenced this in commit 3eb43226cd on Jan 6, 2019
- CryptoCentric referenced this in commit 935a8cc3db on Feb 25, 2019
- random-zebra referenced this in commit 5fcad0c139 on Aug 2, 2020
- zkbot referenced this in commit b9504dbb3f on Jan 28, 2021
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels