Fix rounding privacy leak introduced in #9260 #9268

1. 
   TheBlueMatt commented at 2:36 AM on December 3, 2016: member

   #9260 accidentally changed behavior of the fee filter rounder - from DEFAULT_MIN_RELAY_TX_FEE to -minrelaytxfee. While technically a violation of our dont-hardcode-values policy, its probably better to use the default here to preserve privacy (which was the original purpose of the rounder, AFAIU).

2. fanquake added the label Privacy on Dec 3, 2016
3. 
   fanquake commented at 2:51 AM on December 3, 2016: member

   Travis failure:

   ../../src/net_processing.cpp:2999:54: error: request for member ‘round’ in ‘filterRounder’, which is of non-class type ‘FeeFilterRounder(CFeeRate)’
                    CAmount filterToSend = filterRounder.round(currentFilter);
   

4. Fix rounding privacy leak introduced in #9260 9b9324ee49
5. TheBlueMatt force-pushed on Dec 3, 2016
6. 
   btcdrak commented at 8:54 PM on December 3, 2016: contributor

   utACK 9b9324e

7. 
   gmaxwell commented at 8:43 AM on December 4, 2016: contributor

   Seems sensible to me.

8. dcousens approved
9. 
   dcousens commented at 1:57 AM on December 6, 2016: contributor

   Tested ACK 9b9324e, fixes a bitcoind deadlock for me (but only with -minrelaytxfee=0.00000001, aka ::minRelayTxFee == CFeeRate(1))

10. MarcoFalke added this to the milestone 0.14.0 on Dec 6, 2016
11. 
    morcos commented at 5:51 PM on December 6, 2016: member

    utACK

12. 
    MarcoFalke commented at 9:24 PM on December 6, 2016: member

    utACK 9b9324e

13. 
    sipa commented at 9:28 PM on December 6, 2016: member

    utACK 9b9324ee49e3e9cd401cedb8cdfce9a4b7c040de

14. sipa merged this on Dec 6, 2016
15. sipa closed this on Dec 6, 2016

    ---

16. sipa referenced this in commit 09c4fd157c on Dec 6, 2016
17. MarcoFalke locked this on Sep 8, 2021

Milestone
0.14.0