Assert FRESH validity in CCoinsViewCache::BatchWrite #9310

1. 
   ryanofsky commented at 6:09 pm on December 9, 2016: member

   This change adds a check for the validity of the FRESH flag in CCoinsViewCache::BatchWrite. The check added here is analogous to the assert @morcos is adding in #9107. It is checking the same condition, just inside a different method (BatchWrite instead of ModifyNewCoins).
2. ryanofsky force-pushed on Dec 9, 2016
3. ryanofsky force-pushed on Dec 9, 2016
4. ryanofsky force-pushed on Dec 9, 2016
5. 
   fanquake commented at 0:14 am on December 10, 2016: member

   Travis is failing on Windows

   0FAIL: test/test_bitcoin
   1=======================
   2Running A218 test cases...
   3ssertion failed!
   4Program: Z:\home\travis\build\bitcoin\bitcoin\build\src\test\test_bitcoin.exe
   5File: ../../src/coins.cpp, Line 194
   6Expression: !(it->second.flags & CCoinsCacheEntry::FRESH) || itUs->second.coins.IsPruned()
   

6. fanquake added the label UTXO Db and Indexes on Dec 14, 2016
7. ryanofsky force-pushed on Dec 19, 2016
8. ryanofsky force-pushed on Dec 20, 2016
9. ryanofsky force-pushed on Dec 21, 2016
10. ryanofsky renamed this:
    Assert FRESH validity in CCoinsViewCache::BatchWrite (on top of #9308)
    Assert FRESH validity in CCoinsViewCache::BatchWrite
    on Dec 21, 2016
11. 
    ryanofsky commented at 2:30 pm on December 21, 2016: member

    Switched from assert to throw std::logic_error to fix the windows tests because boost execution monitor isn’t able to catch asserts on windows. (Previous implementation with boost execution monitor is here: https://github.com/ryanofsky/bitcoin/commit/c3ba2d33eff8d1956b5502044854f8431ca4186d)
12. 
    sipa commented at 10:53 pm on January 3, 2017: member

    utACK ac10e1759910e2f14ea1d8f0912aa414047069a6
13. Check FRESH validity in CCoinsViewCache::BatchWrite dd44ea39bb
14. ryanofsky force-pushed on Jan 4, 2017
15. 
    ryanofsky commented at 8:22 pm on January 4, 2017: member

    Rebased to avoid merge conflict (in ccoins_test) with #9107.
16. 
    morcos commented at 5:55 pm on January 5, 2017: member

    utACK dd44ea3
17. 
    TheBlueMatt commented at 1:55 am on January 8, 2017: member

    utACK dd44ea39bb6e1e2a244630909647ea7fbb052941 (didn’t look too hard at tests, though).
18. sipa merged this on Jan 9, 2017
19. sipa closed this on Jan 9, 2017

    ---

20. sipa referenced this in commit 8c87f175d3 on Jan 9, 2017
21. codablock referenced this in commit e61ebbe411 on Sep 27, 2017
22. codablock referenced this in commit 319d8b1c12 on Oct 12, 2017
23. codablock referenced this in commit f2cf50ebf9 on Oct 23, 2017
24. codablock referenced this in commit 09b3e042f4 on Oct 23, 2017
25. UdjinM6 referenced this in commit 056ae0c6cd on Nov 8, 2017
26. random-zebra referenced this in commit af793b7bb9 on Aug 18, 2020
27. MarcoFalke locked this on Sep 8, 2021

Contributors
ryanofsky fanquake sipa morcos TheBlueMatt

Labels
UTXO Db and Indexes