Request announcement by cmpctblock AFTER requesting cmpctblock/blocktxn #9315

pull rebroad wants to merge 1 commits into bitcoin:master from rebroad:RequestAnnounceAfter changing 1 files +10 −7

rebroad commented at 10:42 AM on December 10, 2016: contributor

This will speed up block propagation since the annoucement request can wait until after we have requested the block data.
fanquake added the label P2P on Dec 10, 2016
gmaxwell commented at 7:19 PM on December 10, 2016: contributor

Is the theory here that it will make it faster because it will move the getdata ahead of the 12 byte sendcmpt message?
rebroad commented at 8:10 AM on December 11, 2016: contributor

@gmaxwell yes, although I prefer to look at the improvement in terms of milliseconds than bytes, and in mining terms that equals money. Then again if all the miners include this code then it's an improvement for no one :)
rebroad force-pushed on Dec 12, 2016
rebroad commented at 3:22 AM on December 13, 2016: contributor

@gmaxwell Also worth bearing in mind that some implementations may round-robin the messages being processed from peers, so changing the order of the messages might mean being one place further forward in the queue for receiving blocks from such a peer.

Oh, and the sendcmpCt message is 33 bytes (including the header, 9 without the header), not 12.

Request announcement by cmpctblock AFTER requesting cmpctblock/blocktxn

This will speed up block propagation since the annoucement request can wait until after we have requested the block data.

d1d86760a3

rebroad force-pushed on Dec 24, 2016
rebroad commented at 4:37 PM on January 3, 2017: contributor

what am I talking about?! since #3180 the bitcoin core implementation round-robins the messages being processed from peers - thus this changing of order is more significant than I'd realised...
TheBlueMatt commented at 4:54 PM on January 3, 2017: member

This would make a noticeable difference in some cases, not sure why I missed this until now.
TheBlueMatt commented at 8:30 PM on January 14, 2017: member

Should be obsoleted by #9400.
fanquake commented at 1:06 AM on January 21, 2017: member

Closing now that #9400 has been merged. If there are still changes here that you'd like reviewed, please rebase and reopen.
fanquake closed this on Jan 21, 2017
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels