Document CWalletTx::mapValue entries and remove erase of nonexistent "version" entry. #9333

pull ryanofsky wants to merge 3 commits into bitcoin:master from ryanofsky:pr/comment-mapvalue changing 1 files +25 −1
  1. ryanofsky commented at 4:42 PM on December 12, 2016: member

    No description provided.

  2. [trivial] Add comment documenting CWalletTx::mapValue 654e0443fb
  3. MarcoFalke commented at 4:45 PM on December 12, 2016: member

    Concept ACK, guess this could go to doxygen as well: https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#doxygen-comments

    On Mon, Dec 12, 2016 at 5:42 PM, Russell Yanofsky notifications@github.com wrote:

    You can view, comment on, or merge this pull request online at:

    #9333 Commit Summary

    • [trivial] Add comment documenting CWalletTx::mapValue

    File Changes

    Patch Links:

    — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/9333, or mute the thread https://github.com/notifications/unsubscribe-auth/AGGmvwyHw-ubxSXuULI1M21IhefCtm8Rks5rHXl8gaJpZM4LKwdn .

  4. ryanofsky force-pushed on Dec 12, 2016
  5. ryanofsky force-pushed on Dec 12, 2016
  6. ryanofsky commented at 6:14 PM on December 12, 2016: member

    Thanks, switched to doxygen comment.

  7. sipa commented at 6:49 PM on December 12, 2016: member

    utACK

  8. fanquake added the label Docs and Output on Dec 13, 2016
  9. fanquake added the label Wallet on Dec 13, 2016
  10. fanquake commented at 3:33 AM on December 13, 2016: member

    utACK

  11. jonasschnelli approved
  12. jonasschnelli commented at 7:23 AM on December 13, 2016: contributor

    Thanks for doing that! ACK 28acf493f3c7cd461635a12e99fc3782dfe082a1

  13. in src/wallet/wallet.h:None in 28acf493f3 outdated 
     255 | +     * serialized in the wallet database:
 256 | +     *
 257 | +     *     "comment", "to"   - comment strings provided to sendtoaddress,
 258 | +     *                         sendfrom, sendmany wallet RPCs
 259 | +     *     "from", "message" - obsolete fields that could be set in UI prior to
 260 | +     *                         2011 (removed 4d9b223)
    paveljanik commented at 8:39 AM on December 13, 2016:

    4d9b223 is the commit hash? github's UI can't find it. If it is commit hash, please add by/in before the ID.

    paveljanik commented at 8:41 AM on December 13, 2016:

    Hmm, search can't find it, but it is hyperlinked to https://github.com/bitcoin/bitcoin/commit/4d9b223ac2b596d93ef772fea27b75d1b959b9ae 8). Interesting. Looks like bug in github's search? ;-)

    ryanofsky commented at 12:21 PM on December 13, 2016:

    Yeah not sure about the github interface. git log 4d9b223 does work though.

  14. in src/wallet/wallet.h:None in 28acf493f3 outdated 
     258 | +     *                         sendfrom, sendmany wallet RPCs
 259 | +     *     "from", "message" - obsolete fields that could be set in UI prior to
 260 | +     *                         2011 (removed 4d9b223)
 261 | +     *
 262 | +     * The following keys are serialized in the wallet database, but shouldn't
 263 | +     * be read or written through the map (they will be temporarily be added and
    paveljanik commented at 8:39 AM on December 13, 2016:

    be... be...

    ryanofsky commented at 12:21 PM on December 13, 2016:

    Thanks, fixed.

  15. in src/wallet/wallet.h:None in 28acf493f3 outdated 
     262 | +     * The following keys are serialized in the wallet database, but shouldn't
 263 | +     * be read or written through the map (they will be temporarily be added and
 264 | +     * removed from the map during serialization):
 265 | +     *
 266 | +     *     "fromaccount"     - serialized strFromAccount value
 267 | +     *     "version"         - serialized nTimeSmart value
    paveljanik commented at 8:40 AM on December 13, 2016:

    version.... nTimeSmart?

    ryanofsky commented at 12:21 PM on December 13, 2016:

    Oops, fixed.

  16. in src/wallet/wallet.h:None in 28acf493f3 outdated 
     266 | +     *     "fromaccount"     - serialized strFromAccount value
 267 | +     *     "version"         - serialized nTimeSmart value
 268 | +     *     "n"               - serialized nOrderPos value
 269 | +     *     "timesmart"       - serialized nTimeSmart value
 270 | +     *     "spent"           - serialized vfSpent value that existed prior to
 271 | +     *                         2014 (removed 93a18a3)
    paveljanik commented at 8:40 AM on December 13, 2016:

    removed by/in

    ryanofsky commented at 12:21 PM on December 13, 2016:

    Thanks, added.

  17. ryanofsky force-pushed on Dec 13, 2016
  18. paveljanik commented at 2:07 PM on December 13, 2016: contributor

    ACK 654e044

  19. Remove reference to nonexistent "version" wallet transaction mapvalue field
    This change removes a mapValue.erase("version") statement which deletes a
mapValue entry that never existed. The statement was mistakenly added in commit
865c3a23832e36d50cb873d38c976032b027b5d3 in 2010 and is harmless but confusing.
    a1fe9446e9
  20. in src/wallet/wallet.h:None in 654e0443fb outdated 
     267 | +     *     "n"               - serialized nOrderPos value
 268 | +     *     "timesmart"       - serialized nTimeSmart value
 269 | +     *     "spent"           - serialized vfSpent value that existed prior to
 270 | +     *                         2014 (removed in commit 93a18a3)
 271 | +     *
 272 | +     * A mapValue.erase("version") statement also appears in the code,
    laanwj commented at 9:11 AM on December 14, 2016:

    utACK - though would prefer to just remove this unnecessary code instead of bother to document it here

    ryanofsky commented at 10:51 AM on December 14, 2016:

    Ok, added another commit to this PR which removes the mapValue.erase("version") statement and this part of the comment.

  21. ryanofsky renamed this:
    [trivial] Add comment documenting CWalletTx::mapValue
    Document CWalletTx::mapValue entries and remove erase of nonexistent "version" entry.
    on Dec 14, 2016
  22. MarcoFalke added the label Refactoring on Dec 14, 2016
  23. MarcoFalke removed the label Docs and Output on Dec 14, 2016
  24. [trivial] Add comment documenting bumpfee mapValues 87ed396159
  25. ryanofsky commented at 6:24 PM on January 25, 2017: member

    New commit 87ed396159974b403d0ac00cb793888174e2665c adds documentation for bumpfee mapvalue entries (added in #8456)

  26. laanwj merged this on Mar 6, 2017
  27. laanwj closed this on Mar 6, 2017
  28. laanwj referenced this in commit fa625b078b on Mar 6, 2017
  29. PastaPastaPasta referenced this in commit 150357022c on Dec 30, 2018
  30. PastaPastaPasta referenced this in commit add11fbf56 on Dec 31, 2018
  31. PastaPastaPasta referenced this in commit 427c28ee12 on Dec 31, 2018
  32. PastaPastaPasta referenced this in commit cb36eb4747 on Dec 31, 2018
  33. PastaPastaPasta referenced this in commit abf8712481 on Jan 2, 2019
  34. PastaPastaPasta referenced this in commit b88cec662a on Jan 2, 2019
  35. PastaPastaPasta referenced this in commit 35ab56b8c3 on Jan 3, 2019
  36. PastaPastaPasta referenced this in commit 1e4539fdbc on Jan 21, 2019
  37. PastaPastaPasta referenced this in commit a862c140bc on Jan 25, 2019
  38. PastaPastaPasta referenced this in commit 1a4ff7165e on Jan 29, 2019
  39. PastaPastaPasta referenced this in commit 0bb6637d81 on Feb 1, 2019
  40. PastaPastaPasta referenced this in commit 127dd6ab97 on Feb 1, 2019
  41. PastaPastaPasta referenced this in commit ca21c8b1f7 on Feb 1, 2019
  42. PastaPastaPasta referenced this in commit 501227deef on Feb 1, 2019
  43. MarcoFalke locked this on Sep 8, 2021
Contributors
ryanofskyMarcoFalkesipafanquakejonasschnellipaveljaniklaanwj
Labels
RefactoringWallet
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 15:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me