De-duplicate SignatureCacheHasher #9480

1. 
   JeremyRubin commented at 1:15 am on January 6, 2017: contributor

   Previously, I duplicated the SignatureCacheHasher in the cuckoocache tests to avoid extra changes/review in the cuckoocache pr. This moves the SignatureCacheHasher to the sigcache header, out of the anonymous namespace, so that the tests can import it.

   Not very critical, but it is good to make sure that these implementations don’t ever diverge by only having this class defined once.

2. fanquake added the label Refactoring on Jan 6, 2017
3. 
   MarcoFalke commented at 1:20 am on January 6, 2017: member

   Everyone-loves-negative-net-diffs ACK 0b829c0
4. dcousens approved
5. 
   NicolasDorier commented at 6:22 am on January 6, 2017: contributor

   utACK 0b829c0
6. 
   paveljanik commented at 10:28 am on January 6, 2017: contributor

   ACK https://github.com/bitcoin/bitcoin/commit/0b829c092977234a5250ce4a14e13b179abe9008
7. 
   gmaxwell commented at 2:58 pm on January 7, 2017: contributor

   utACK
8. 
   morcos commented at 3:11 pm on January 7, 2017: member

   utACK but please don’t mark this as trivial
9. MarcoFalke renamed this:
   [trivial] De-duplicate SignatureCacheHasher
   De-duplicate SignatureCacheHasher
   on Jan 7, 2017
10. 
    TheBlueMatt commented at 7:01 pm on January 7, 2017: member

    utACK
11. 
    ryanofsky commented at 7:49 pm on January 11, 2017: member

    utACK, checked moved/copied code is the same.
12. JeremyRubin force-pushed on Mar 28, 2017
13. 
    JeremyRubin commented at 5:15 pm on March 28, 2017: contributor

    I reworded the commit because I had accidentally used trivial in it originally.

    Code move not changed.

14. 
    TheBlueMatt commented at 4:45 pm on April 12, 2017: member

    Needs rebase.
15. JeremyRubin force-pushed on Apr 12, 2017
16. 
    JeremyRubin commented at 5:07 pm on April 12, 2017: contributor

    rebased
17. 
    TheBlueMatt commented at 5:26 pm on April 12, 2017: member

    Please add an extra line between the commit title and the commit message, for some reason git likes to think that its all intended as a multi-line-super-long title if you dont.
18. Deduplicate SignatureCacheHasher

    This moves the SignatureCacheHasher to the sigcache header, out of the anonymous
    namespace, so that the tests can import it.

    f9c88079df
19. JeremyRubin force-pushed on Apr 12, 2017
20. 
    JeremyRubin commented at 9:44 pm on April 12, 2017: contributor

    @TheBlueMatt I think that’s a local issue in your git client settings, I can’t reproduce it. Nonetheless, I inserted an additional newline.
21. sipa merged this on Apr 13, 2017
22. sipa closed this on Apr 13, 2017

    ---

23. sipa referenced this in commit b7365f0545 on Apr 13, 2017
24. 
    jtimon commented at 4:14 pm on April 18, 2017: contributor

    after-merge utACK f9c88079df8b78b8fab75e0903ca395654f2d360
25. PastaPastaPasta referenced this in commit 9f3749187a on May 21, 2019
26. PastaPastaPasta referenced this in commit 873dd00872 on May 21, 2019
27. PastaPastaPasta referenced this in commit 000e307747 on May 22, 2019
28. PastaPastaPasta referenced this in commit 8e55395e8b on May 22, 2019
29. PastaPastaPasta referenced this in commit 06704ac096 on May 22, 2019
30. PastaPastaPasta referenced this in commit 6fd99293c1 on May 22, 2019
31. PastaPastaPasta referenced this in commit 55d1251ffc on May 23, 2019
32. UdjinM6 referenced this in commit f384489c1f on May 28, 2019
33. barrystyle referenced this in commit 5de0c946f3 on Jan 22, 2020
34. random-zebra referenced this in commit c072659135 on Jul 3, 2020
35. DrahtBot locked this on Sep 8, 2021

Contributors
JeremyRubin MarcoFalke dcousens NicolasDorier paveljanik gmaxwell morcos TheBlueMatt ryanofsky jtimon

Labels
Refactoring