Remove min reasonable fee #9548

1. 
   morcos commented at 10:01 pm on January 13, 2017: member

   This builds off of #9380… It’s just a cleanup PR and should be no change in functionality.

   Previously the minReasonableRelayFee which was passed through CTxMempool to CBlockPolicyEstimator was just getting its statically initialized value of DEFAULT_MIN_RELAY_TX_FEE so this PR shortcuts passing it through for no reason.

   It’s perfectly fine to have a smaller min bucket feerate in fee estimation, it is just slightly less space efficient. However changing this number invalidates old fee estimate files.. So we change the hardcoded minimum rate to be the same rate that was being passed in previously (1000 from DEFAULT_MIN_RELAY_TX_FEE) and we can worry about changing it in the future if that ever becomes not small enough. @theuni

2. fanquake added the label TX fees and policy on Jan 13, 2017
3. Change fee estimation bucket limit variable names ac9d3d25f7
4. CBlockPolicyEstimator now uses hard coded minimum bucket feerate 2a7b56cc0e
5. Remove unnecessary min fee argument in CTxMemPool constructor ad82cb06ce
6. morcos force-pushed on Jan 17, 2017
7. 
   morcos commented at 6:23 pm on January 17, 2017: member

   rebased
8. 
   theuni commented at 7:18 pm on January 17, 2017: member

   utACK ad82cb06cecf84c4f9e5647b404b7eb19f1e9bf3.

   To help other reviewers: The mempool previously accepted an argument that appeared to be coming from the “-minrelaytxfee” option, but in reality (as @morcos said above) the CTxMempool had already been statically created with DEFAULT_MIN_RELAY_TX_FEE before the option was parsed: https://github.com/bitcoin/bitcoin/blob/master/src/validation.cpp#L86

9. 
   MarcoFalke commented at 8:38 pm on January 17, 2017: member

   ACK ad82cb0
10. 
    TheBlueMatt commented at 8:31 pm on February 23, 2017: member

    utACK ad82cb06cecf84c4f9e5647b404b7eb19f1e9bf3.
11. 
    ryanofsky commented at 11:23 pm on February 27, 2017: member

    utACK ad82cb06cecf84c4f9e5647b404b7eb19f1e9bf3
12. gmaxwell approved
13. 
    gmaxwell commented at 6:36 pm on March 7, 2017: contributor

    utACK.
14. laanwj merged this on Mar 7, 2017
15. laanwj closed this on Mar 7, 2017

    ---

16. laanwj referenced this in commit 47510ad3dd on Mar 7, 2017
17. PastaPastaPasta referenced this in commit dfabe68df4 on Jan 2, 2019
18. PastaPastaPasta referenced this in commit b8057a4a5c on Jan 2, 2019
19. PastaPastaPasta referenced this in commit 7b0ba59565 on Jan 2, 2019
20. PastaPastaPasta referenced this in commit f9bd7922f1 on Jan 3, 2019
21. PastaPastaPasta referenced this in commit 55e90f8bb3 on Jan 21, 2019
22. PastaPastaPasta referenced this in commit 75896158e0 on Jan 27, 2019
23. PastaPastaPasta referenced this in commit 3ffccfbf13 on Jan 29, 2019
24. PastaPastaPasta referenced this in commit 25d4a670b5 on Feb 5, 2019
25. PastaPastaPasta referenced this in commit 45ca7753c9 on Feb 5, 2019
26. PastaPastaPasta referenced this in commit b1d64f3a14 on Feb 5, 2019
27. MarcoFalke locked this on Sep 8, 2021

Contributors
morcos theuni MarcoFalke TheBlueMatt ryanofsky gmaxwell

Labels
TX fees and policy