Remove unused, non-working RPC PostCommand signal #9575

1. 
   practicalswift commented at 4:51 pm on January 18, 2017: contributor
2. 
   TheBlueMatt commented at 1:57 am on January 19, 2017: member

   I’d vote we just remove the dead code.
3. 
   fanquake commented at 2:34 am on January 19, 2017: member

   0I'd vote we just remove the dead code.
   

   Agree.

4. 
   JeremyRubin commented at 4:32 am on January 19, 2017: contributor

   NACK. Code seems to be reachable?

   JSONRPCError doesn’t inherit from std::exception. transformNamedArguments could throw a JSONRPCError.

5. 
   TheBlueMatt commented at 4:55 am on January 19, 2017: member

   Either way, code is clearly a NOP.

   On January 18, 2017 11:32:42 PM EST, Jeremy Rubin notifications@github.com wrote:

   NACK. Code seems to be reachable?

   JSONRPCError doesn’t inherit from std::exception. transformNamedArguments could throw a JSONRPCError.

   – You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/bitcoin/bitcoin/pull/9575#issuecomment-273679792

6. 
   laanwj commented at 6:09 am on January 19, 2017: member

   This clearly seems a bug. There’s two options here:

   • repair the PostCommand functionality so that the PostCommand handler actually runs (by having a RAII cleanup that triggers it)
   • remove the PostCommand functionality

   It looks like this currently influences nothing as no PostCommand handlers are being registered.

7. practicalswift force-pushed on Feb 28, 2017
8. 
   practicalswift commented at 3:42 pm on February 28, 2017: contributor

   @laanwj Updated and pushed. I simply removed the PostCommand functionality as suggested. Let me know if you have any further suggestions! :-)
9. practicalswift renamed this:
   [trivial] Add comment about unreachable code
   Remove unreachable code
   on Feb 28, 2017
10. 
    laanwj commented at 7:28 am on March 9, 2017: member

    @practicalswift You should more thoroughly remove it then. Also remove the signal. Otherwise people will register it in the expectation it will be called.
11. Remove unreachable code (g_rpcSignals.PostCommand) 54fae05dad
12. practicalswift force-pushed on Mar 9, 2017
13. 
    practicalswift commented at 8:48 am on March 9, 2017: contributor

    @laanwj Another try - looks good? :-)
14. 
    laanwj commented at 8:50 am on March 9, 2017: member

    Yes, all the traces of it should be gone. Looks good to me now. (also renamed the pull to more clearly summarize what it does)
15. laanwj renamed this:
    Remove unreachable code
    Remove unused, non-working RPC PostCommand signal
    on Mar 9, 2017
16. laanwj merged this on Mar 9, 2017
17. laanwj closed this on Mar 9, 2017

    ---

18. laanwj referenced this in commit 6805c4112c on Mar 9, 2017
19. PastaPastaPasta referenced this in commit 40b53015ea on Jan 2, 2019
20. PastaPastaPasta referenced this in commit a43bd9a611 on Jan 2, 2019
21. PastaPastaPasta referenced this in commit a5d406ff27 on Jan 2, 2019
22. PastaPastaPasta referenced this in commit 297d1037a6 on Jan 3, 2019
23. PastaPastaPasta referenced this in commit 329ab599f7 on Jan 21, 2019
24. PastaPastaPasta referenced this in commit 4658e17409 on Jan 27, 2019
25. PastaPastaPasta referenced this in commit f7f589161c on Jan 29, 2019
26. PastaPastaPasta referenced this in commit 77757b6c3e on Feb 5, 2019
27. PastaPastaPasta referenced this in commit 77119e97d4 on Feb 5, 2019
28. PastaPastaPasta referenced this in commit 1bfc069e34 on Feb 5, 2019
29. Fuzzbawls referenced this in commit 71ed429370 on Feb 14, 2021
30. practicalswift deleted the branch on Apr 10, 2021
31. DrahtBot locked this on Aug 16, 2022

Contributors
practicalswift TheBlueMatt fanquake JeremyRubin laanwj