[trivial] Fix recently introduced typos in comments #9696

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:fix-recently-introduced-typos changing 8 files +12 −12

practicalswift commented at 2:17 PM on February 6, 2017: contributor

No description provided.
fanquake commented at 2:20 PM on February 6, 2017: member

Couldn't you have merged this into one of the two just-merged typo PRs. Rather than opening an pull-request to fix the same thing.

I can't believe new typos are being re-introduced this quickly anyways.
fanquake added the label Docs and Output on Feb 6, 2017
practicalswift commented at 2:50 PM on February 6, 2017: contributor
These typos were are all introduced in fairly recently merged PRs:
- src/init.cpp: minimimum (minimum) - typo introduced in 7b1add3c28aae8caf2e1517f15cd953eacbb4931 on December 13:th
- src/rpc/client.cpp: Specifiy (Specify) - typo introduced in 481f289765fab47ff2e0bd7dfb968f2bd92fd608 on November 12:th
- src/rpc/misc.cpp: callsites (call sites) - typo introduced in 99464bc38e9575ff47f8e33223b252dcea2055e3 on January 19:th
- src/utiltime.h: sytem (system) - typo introduced in 99464bc38e9575ff47f8e33223b252dcea2055e3 on January 19:th
- src/validation.cpp: assumedvalid (assumevalid) - typo introduced in e440ac7ef3b6f3ad1cd8fc7027cece40413202d9 on January 6:th
- src/validation.cpp: hashpower (hash power) - typo introduced in e440ac7ef3b6f3ad1cd8fc7027cece40413202d9 on January 6:th
- src/validation.cpp: inadvertantly (inadvertently) - typo introduced in 4afbde6028708541c4da8732a1bd12fb8735fdae on December 16:th
- src/validation.cpp: connnected (connected) - typo introduced in 4afbde6028708541c4da8732a1bd12fb8735fdae on December 16:th
- src/validationinterface.h: tranactions (transactions) - typo introduced in 094e4b33839404d9c18200fc30d9a993a3dc106f on December 16:th
- src/wallet/rpcwallet.cpp: replacable (replaceable) - typo introduced in cc0243ad32cee1cc9faab317364b889beaf07647 on December 9:th
- src/wallet/wallet.cpp: carefuly (carefully) - typo introduced in 094e4b33839404d9c18200fc30d9a993a3dc106f on December 16:th
Please note that these are commit dates. Merge dates are likely a few weeks later on average.
MarcoFalke commented at 12:26 PM on February 7, 2017: member

utACK 2152f8e. In the future I'd suggest this is done only every 6 months (prior to every release).
jonasschnelli approved
jonasschnelli commented at 12:46 PM on February 7, 2017: contributor

Great. Trivial ACK 2152f8ee274839e85464937223ca1247d4dd5441
paveljanik commented at 2:21 PM on February 7, 2017: contributor

ACK https://github.com/bitcoin/bitcoin/commit/2152f8ee274839e85464937223ca1247d4dd5441
practicalswift commented at 6:30 PM on February 9, 2017: contributor

Fixed another typo ("tempoarily" → "temporarily"): 719292bbaeca1a0e4ae1d0e3c0823f0fca00ed05
practicalswift commented at 7:08 PM on February 14, 2017: contributor

Anything needed before merge? :-)
paveljanik commented at 7:11 PM on February 14, 2017: contributor

@practicalswift Please squash
[trivial] Fix recently introduced typos in comments 0c9b9b7d64
practicalswift force-pushed on Feb 14, 2017
practicalswift commented at 7:20 PM on February 14, 2017: contributor

@paveljanik Squashed and pushed! :-)
paveljanik commented at 7:34 PM on February 14, 2017: contributor

reACK https://github.com/bitcoin/bitcoin/pull/9696/commits/0c9b9b7d646333cb3212f1bea98e629c416cbe42
fanquake commented at 12:44 PM on February 16, 2017: member

utACK 0c9b9b7
MarcoFalke merged this on Feb 18, 2017
MarcoFalke closed this on Feb 18, 2017
MarcoFalke referenced this in commit aa5fa642b0 on Feb 18, 2017
MarcoFalke commented at 11:15 AM on February 18, 2017: member

utACK 0c9b9b7. @practicalswift If you find some more typos, that is great, but please wait a few months until submitting a pull request. We have no pressure to fix all typos immediately, it is enough to do it twice a year or something.
PastaPastaPasta referenced this in commit 50ae5bd5c4 on Dec 28, 2018
PastaPastaPasta referenced this in commit df870f4140 on Dec 29, 2018
PastaPastaPasta referenced this in commit 3af098d7cc on Dec 29, 2018
UdjinM6 referenced this in commit a49f4123e5 on Jan 3, 2019
CryptoCentric referenced this in commit c632f583ae on Jul 11, 2019
practicalswift deleted the branch on Apr 10, 2021
DrahtBot locked this on Aug 16, 2022

Contributors

Labels