A new round of typo fixes :-)
Fix typos #9651
pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:typos changing 7 files +9 −9-
practicalswift commented at 5:08 PM on January 29, 2017: contributor
- fanquake added the label Docs and Output on Jan 29, 2017
-
fanquake commented at 5:16 PM on January 29, 2017: member
You need to submit secp256k1 changes upstream.
-
Fix typos 5f62e3eb63
- practicalswift force-pushed on Jan 29, 2017
-
practicalswift commented at 5:25 PM on January 29, 2017: contributor
Typo fixes in
src/secp256k1/now excluded! -
practicalswift commented at 5:28 PM on January 29, 2017: contributor
@fanquake Is https://github.com/bitcoin-core/secp256k1 the correct upstream repo for secp256k1?
-
fanquake commented at 5:29 PM on January 29, 2017: member
https://github.com/bitcoin-core/secp256k1
On Sun, 29 Jan 2017 at 17:27, practicalswift notifications@github.com wrote:
@fanquake https://github.com/fanquake Perhaps a stupid question, but what is the correct upstream repo for secp256k1?
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/9651#issuecomment-275930021, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0t8s23XXvjxBcgpBGFbjlH5gvstXuaks5rXMvngaJpZM4Lw16e .
-
practicalswift commented at 5:38 PM on January 29, 2017: contributor
secp256k1 typos submitted in https://github.com/bitcoin-core/secp256k1/pull/440
-
MarcoFalke commented at 6:13 PM on January 29, 2017: member
If you have more typos to fix or plan to do so, please include all typo fixes in a single commit in this pull. This will aid review, whereas multiple successive or parallel pull request to fix typos will distract reviewers.
-
practicalswift commented at 6:55 PM on January 29, 2017: contributor
@MarcoFalke The only remaining typo fixes I have in store pertain to:
contrib/debian/changelogdoc/release-notes/
Are these of interest or is the policy to keep release notes/changelogs frozen post-release?
-
fanquake commented at 7:47 AM on January 30, 2017: member
We haven't been modifying old changelogs in this repo. On Sun, 29 Jan 2017 at 18:55, practicalswift notifications@github.com wrote:
@MarcoFalke https://github.com/MarcoFalke The only remaining typo fixes I have in store pertain to:
- contrib/debian/changelog
- doc/release-notes/
Are these of interest of should release notes/changelogs be frozen post-release?
— You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/bitcoin/bitcoin/pull/9651#issuecomment-275936690, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0t8h4pgCxsWnOt7FvxWYNB6DAXXVsMks5rXOC1gaJpZM4Lw16e .
-
laanwj commented at 12:01 PM on January 31, 2017: member
Are these of interest or is the policy to keep release notes/changelogs frozen post-release?
Historical changelog entries shouldn't be changed. If there is a critical mistake that can lead to funds loss of anyone reading it, or exploitable behavior, I'm sure an exception could be made. But not for typos.
-
practicalswift commented at 6:35 PM on January 31, 2017: contributor
@laanwj Sounds reasonable! :-) I'll skip submitting the changelog typo PR
- unknown approved
- laanwj merged this on Feb 6, 2017
- laanwj closed this on Feb 6, 2017
- laanwj referenced this in commit 986ba005ed on Feb 6, 2017
-
practicalswift commented at 1:22 PM on February 6, 2017: contributor
@laanwj Thanks for merging! We are now officially typo free :-)
-
laanwj commented at 1:51 PM on February 6, 2017: member
@practicalswift Good! :)
-
practicalswift commented at 2:18 PM on February 6, 2017: contributor
- codablock referenced this in commit 207e9ec7bc on Jan 19, 2018
- codablock referenced this in commit 81eeb0dee7 on Jan 23, 2018
- andvgal referenced this in commit 55f3bf24eb on Jan 6, 2019
- CryptoCentric referenced this in commit 3a01a10bfe on Feb 27, 2019
- practicalswift deleted the branch on Apr 10, 2021
- DrahtBot locked this on Aug 16, 2022
Contributors
Labels