Remove code for Cap'n Proto versions before 0.9 #331

pull hebasto wants to merge 1 commits into bitcoin-core:master from hebasto:260802-outdated-capnp changing 3 files +1 −49

hebasto commented at 5:05 PM on August 2, 2026: member

The removed code has been dead since db4f9a3d7395d435c484f5735a787f0798080c52, which bumped the minimum required Cap'n Proto version to 0.9.
DrahtBot commented at 5:06 PM on August 2, 2026: none



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline and AI policy for information on the review process.

Type Reviewers

ACK maflcko, ryanofsky

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.
hebasto renamed this:
~~Remove code for for Cap'n Proto versions before 0.9~~
Remove code for Cap'n Proto versions before 0.9
on Aug 2, 2026

Type	Reviewers
ACK	maflcko, ryanofsky

Remove code for Cap'n Proto versions before 0.9

The removed code has been dead since db4f9a3d7395d435c484f5735a787f0798080c52,
which bumped the minimum required Cap'n Proto version to 0.9.

788f17a850

hebasto force-pushed on Aug 2, 2026
maflcko commented at 5:31 AM on August 3, 2026: contributor

lgtm ACK 788f17a850942448f84e543aeefda3ac6c577327
in shell.nix:23 in 788f17a850
```
  16 | @@ -17,10 +17,6 @@ let
  17 |      };
  18 |    };
  19 |    capnprotoHashes = {
  20 | -    "0.7.0" = "sha256-Y/7dUOQPDHjniuKNRw3j8dG1NI9f/aRWpf8V0WzV9k8=";
  21 | -    "0.7.1" = "sha256-3cBpVmpvCXyqPUXDp12vCFCk32ZXWpkdOliNH37UwWE=";
  22 | -    "0.8.0" = "sha256-rfiqN83begjJ9eYjtr21/tk1GJBjmeVfa3C3dZBJ93w=";
  23 | -    "0.8.1" = "sha256-OZqNVYdyszro5rIe+w6YN00g6y8U/1b8dKYc214q/2o=";
```
ryanofsky commented at 10:03 PM on August 3, 2026:

In commit "Remove code for Cap'n Proto versions before 0.9" (788f17a850942448f84e543aeefda3ac6c577327)

Other changes in this commit all make sense, but I do think it'd be a little nicer to keep these hashes as they are convenient for testing. The dependency on 0.9.0 is weak and only due to a getFd call which I think we may want to drop anyway, because capnproto has long had better mechanisms for communicating across threads than writing to file descriptors: #274 (review)
ryanofsky approved
ryanofsky commented at 10:07 PM on August 3, 2026: collaborator

Code review ACK 788f17a850942448f84e543aeefda3ac6c577327. It's especially nice to clean up the cmake/compat_config.cmake file
ryanofsky merged this on Aug 3, 2026
ryanofsky closed this on Aug 3, 2026
hebasto deleted the branch on Aug 4, 2026

Contributors