cmake: add type-unordered-set.h and version.h to public headers #350

pull ryanofsky wants to merge 1 commits into bitcoin-core:master from ryanofsky:pr/newheaders changing 1 files +3 −1

ryanofsky commented at 12:08 PM on August 20, 2026: collaborator

These are useful for building bitcoin core with WITH_EXTERNAL_LIBMULTIPROCESS and having the install target install the complete set of public headers more generally.

cmake: add type-unordered-set.h and version.h to public headers

This ensures all headers are properly installed, and is useful for
building bitcoin core with WITH_EXTERNAL_LIBMULTIPROCESS.

2448d282cc

DrahtBot commented at 12:08 PM on August 20, 2026: none



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Reviews

See the guideline and AI policy for information on the review process.

Type Reviewers

ACK hebasto, xyzconstant

If your review is incorrectly listed, please copy-paste <code></code> into the comment that the bot should ignore.

Type	Reviewers
ACK	hebasto, xyzconstant

in CMakeLists.txt:181 in 2448d282cc

 173 | @@ -174,9 +174,11 @@ set(MP_PUBLIC_HEADERS
 174 |    include/mp/type-struct.h
 175 |    include/mp/type-threadmap.h
 176 |    include/mp/type-tuple.h
 177 | +  include/mp/type-unordered-set.h
 178 |    include/mp/type-vector.h
 179 |    include/mp/type-void.h
 180 | -  include/mp/util.h)
 181 | +  include/mp/util.h
 182 | +  include/mp/version.h)

hebasto commented at 12:30 PM on August 23, 2026:

Agreed. In the Bitcoin Core repo:

$ git grep "mp/version.h" -- ":(exclude)src/ipc/libmultiprocess/"
src/ipc/util.h:#include <mp/version.h>

in CMakeLists.txt:177 in 2448d282cc

 173 | @@ -174,9 +174,11 @@ set(MP_PUBLIC_HEADERS
 174 |    include/mp/type-struct.h
 175 |    include/mp/type-threadmap.h
 176 |    include/mp/type-tuple.h
 177 | +  include/mp/type-unordered-set.h

hebasto commented at 12:32 PM on August 23, 2026:

This header doesn't seem to be used in Bitcoin Core outside of src/ipc/libmultiprocess/:

$ git grep "mp/type-unordered-set.h" -- ":(exclude)src/ipc/libmultiprocess/" | wc -l
0

However, it's better to treat it like the other mp/type-*.h headers. This line effectively amends #277.

hebasto approved
hebasto commented at 12:38 PM on August 23, 2026: member

ACK 2448d282ccdbbe739d097463c070a1a89dc21cd2.
xyzconstant commented at 6:04 PM on August 25, 2026: contributor

ACK 2448d282ccdbbe739d097463c070a1a89dc21cd2
ryanofsky merged this on Aug 26, 2026
ryanofsky closed this on Aug 26, 2026

Contributors

cmake: add type-unordered-set.h and version.h to public headers #350

Reviews