gen: make `AccessorType` static #386

pull fanquake wants to merge 3 commits into bitcoin-core:master from fanquake:static_AccessorType changing 3 files +3 −3
  1. fanquake commented at 2:08 PM on November 3, 2026: member
    [4/62] Building CXX object CMakeFiles/mpgen.dir/src/mp/gen.cpp.o
    libmultiprocess/src/mp/gen.cpp:208:13: warning: no previous prototype for function 'AccessorType' [-Wmissing-prototypes]
      208 | std::string AccessorType(kj::StringPtr base_name, const Field& field)
          |             ^
    libmultiprocess/src/mp/gen.cpp:208:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
      208 | std::string AccessorType(kj::StringPtr base_name, const Field& field)
          | ^
          | static
    1 warning generated.
    

    Used downstream in https://github.com/bitcoin/bitcoin/pull/36743.

  2. DrahtBot commented at 2:08 PM on November 3, 2026: none

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline and AI policy for information on the review process.

    Type Reviewers
    ACK ryanofsky
    Stale ACK maflcko

    If your review is incorrectly listed, please copy-paste <code>&lt;!--meta-tag:bot-skip--&gt;</code> into the comment that the bot should ignore.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  3. maflcko commented at 2:36 PM on November 3, 2026: contributor

    lgtm ACK eb14bcf8dcea87fc3a39580a16347f4673dbca1a

  4. gen: make AccessorType static
    [4/62] Building CXX object CMakeFiles/mpgen.dir/src/mp/gen.cpp.o
    libmultiprocess/src/mp/gen.cpp:208:13: warning: no previous prototype for function 'AccessorType' [-Wmissing-prototypes]
      208 | std::string AccessorType(kj::StringPtr base_name, const Field& field)
          |             ^
    libmultiprocess/src/mp/gen.cpp:208:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
      208 | std::string AccessorType(kj::StringPtr base_name, const Field& field)
          | ^
          | static
    1 warning generated.
    52a028c8b7
  5. ci: add -Wmissing-prototypes to LLVM config 641c78ecac
  6. fanquake force-pushed on Nov 3, 2026
  7. fanquake commented at 3:41 PM on November 3, 2026: member

    Rebased after #362.

  8. in ci/configs/llvm.bash:5 in 641c78ecac outdated
       1 | @@ -2,7 +2,7 @@ CI_DESC="CI job using LLVM-based libraries and tools (clang, libc++, clang-tidy,
       2 |  CI_DIR=build-llvm
       3 |  NIX_ARGS=(--arg enableLibcxx true)
       4 |  export CXX=clang++
       5 | -export CXXFLAGS="-Werror -Wall -Wextra -Wextra-semi -Wpedantic -Wundef -Wthread-safety -Wunused -Wunused-const-variable -Wno-c++23-lambda-attributes"
       6 | +export CXXFLAGS="-Werror -Wall -Wextra -Wextra-semi -Wmissing-prototypes -Wpedantic -Wundef -Wthread-safety -Wunused -Wunused-const-variable -Wno-c++23-lambda-attributes"
    


    ryanofsky commented at 4:23 PM on November 3, 2026:

    In commit "ci: add -Wmissing-prototypes to LLVM config" (641c78ecacb44b06ff8524c1209fb89fab955abf)

    Could also add -Wmissing-declarations to ci/configs/default.bash, which is GCC's equivalent for C++ (GCC only accepts -Wmissing-prototypes for C), so the GCC jobs catch this too. bitcoin/bitcoin#36743 enables both. Fine to leave for a follow-up.


    fanquake commented at 4:29 PM on November 3, 2026:

    Thanks, added that to default.bash.

  9. ryanofsky approved
  10. ryanofsky commented at 4:24 PM on November 3, 2026: collaborator

    Code review ACK 641c78ecacb44b06ff8524c1209fb89fab955abf. Thanks for adding the CI flag along with the fix.

  11. ci: add -Wmissing-declarations to default.bash c8ca0c0f6f
  12. ryanofsky approved
  13. ryanofsky commented at 4:50 PM on November 3, 2026: collaborator

    Code review ACK c8ca0c0f6f1978eb65ff69d565d0a0e0753554ec. Since last review, just added -Wmissing-declarations to the GCC CI config. Thanks!

  14. ryanofsky merged this on Nov 3, 2026
  15. ryanofsky closed this on Nov 3, 2026

  16. fanquake deleted the branch on Nov 3, 2026

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/libmultiprocess. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-11-17 18:30 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me