Examples should not retry on bad randomness keys in a loop #1570

issue real-or-random openend this issue on July 12, 2024
  1. real-or-random commented at 3:25 pm on July 12, 2024: contributor

    Well, we should change the other examples and perhaps also the API docs. Creating keys in a while loop is not good practice. If you hit an invalid key, you’re most probably not very lucky, but very unlucky because your randomness is broken. But hey, yeah, let’s just yolo and try again. :)

    Originally posted by @real-or-random in #1519 (review)

  2. real-or-random added the label user-documentation on Jul 12, 2024
  3. real-or-random added the label refactor/smell on Jul 12, 2024
  4. real-or-random added the label good first issue on Jul 12, 2024
  5. jonasnick referenced this in commit 01b5893389 on Oct 13, 2024
  6. real-or-random referenced this in commit 18f9b967c2 on Oct 14, 2024
  7. real-or-random commented at 3:49 pm on November 1, 2024: contributor
    Resolved by #1570 and #1616.
  8. real-or-random closed this on Nov 1, 2024


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-21 17:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me