Rename member field according to the style guide #10835

pull paveljanik wants to merge 1 commits into bitcoin:master from paveljanik:20170715_Wshadow_reverseiterator changing 1 files +9 −9

paveljanik commented at 7:08 PM on July 15, 2017: contributor

After #10193, approx. five instances of this warning are printed when compiling with -Wshadow:

In file included from txmempool.cpp:14:
./reverse_iterator.h:20:22: warning: declaration shadows a field of 'reverse_range<T>' [-Wshadow]
    reverse_range(T &x) : x(x) {}
                     ^
./reverse_iterator.h:17:8: note: previous declaration is here
    T &x;
       ^
1 warning generated.

sipa commented at 7:14 PM on July 15, 2017: member

If you're going to change this anyway, would you mind switching to the style guidelines? (m_x for the field, x for the parameter).
Rename member field according to the style guide. 4d4fb33fce
paveljanik force-pushed on Jul 15, 2017
paveljanik commented at 7:20 PM on July 15, 2017: contributor

@sipa Like this?

Any other issue with the file?
paveljanik renamed this:
~~Do not shadow a field of 'reverse_range<T>'~~
Rename member field according to the style guide
on Jul 15, 2017
practicalswift commented at 7:23 PM on July 15, 2017: contributor

utACK 4d4fb33fce0803f9c923307bdf82b8fdd2ed140b

Nice!
meshcollider commented at 8:14 PM on July 15, 2017: contributor

utACK https://github.com/bitcoin/bitcoin/commit/4d4fb33fce0803f9c923307bdf82b8fdd2ed140b
fanquake added the label Refactoring on Jul 16, 2017
TheBlueMatt commented at 10:57 PM on July 16, 2017: member

utACK 4d4fb33fce0803f9c923307bdf82b8fdd2ed140b
fanquake commented at 9:37 AM on August 9, 2017: member

utACK 4d4fb33
MarcoFalke commented at 10:07 AM on August 9, 2017: member

utACK 4d4fb33fce0803f9c923307bdf. This gives the same binaries and does not conflict with any open pull request tagged for 0.15, so should be fine to merge.
MarcoFalke merged this on Aug 9, 2017
MarcoFalke closed this on Aug 9, 2017
MarcoFalke referenced this in commit e526ca6284 on Aug 9, 2017
PastaPastaPasta referenced this in commit 3f4130a57a on Sep 8, 2019
PastaPastaPasta referenced this in commit 86a8b30637 on Sep 8, 2019
PastaPastaPasta referenced this in commit 3e7ff33068 on Sep 8, 2019
barrystyle referenced this in commit 47b1eabed7 on Jan 22, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#10193 scripted-diff: Remove #include <boost/foreach.hpp>