Document the preference of nullptr over NULL or (void*)0 #11066

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:document-nullptr-preference changing 4 files +8 −7

practicalswift commented at 3:28 PM on August 16, 2017: contributor
Document the preference of nullptr over NULL or (void*)0.

After this commit:
```
$ git grep "[^A-Za-z_]NULL[^A-Za-z_]" | grep -vE '(leveldb|univalue|secp256k1|torcontrol|NULL certificates|ctaes|release-notes|patches|configure.ac|developer-notes)'
$
```
Some context:
- NULL → nullptr was handled in the recently merged PR #10483
- 0 → nullptr was handled in the recently merged PR #10645
promag commented at 3:32 PM on August 16, 2017: member

utACK 12e881b.

BTW, should be if (psomething) or if (psomething != nullptr), etc?
TheBlueMatt commented at 3:43 PM on August 16, 2017: member

utACK
MarcoFalke added the label Docs and Output on Aug 16, 2017
MarcoFalke commented at 3:57 PM on August 16, 2017: member

utACK
gmaxwell approved
gmaxwell commented at 5:04 PM on August 16, 2017: contributor

ACK.
sipa commented at 6:17 PM on August 16, 2017: member

utACK 12e881b4ded62c0b09f9a09df5b2efc1966db50b

paveljanik commented at 6:30 PM on August 16, 2017: contributor

utACK https://github.com/bitcoin/bitcoin/pull/11066/commits/12e881b4ded62c0b09f9a09df5b2efc1966db50b

Can you please handle these:

src/qt/macdockiconhandler.mm:static MacDockIconHandler *s_instance = NULL;
src/qt/macdockiconhandler.mm:    if (appInst != NULL) {
src/qt/macdockiconhandler.mm:    this->setMainWindow(NULL);
src/qt/macdockiconhandler.mm:    this->setMainWindow(NULL);
src/qt/macnotificationhandler.mm:    static MacNotificationHandler *s_instance = NULL;

practicalswift force-pushed on Aug 16, 2017
practicalswift commented at 7:00 PM on August 16, 2017: contributor

@paveljanik Fixed! :-)
fanquake commented at 12:37 AM on August 17, 2017: member

utACK 3f3cf36
dcousens approved
laanwj commented at 7:21 AM on August 17, 2017: member

Can you please handle these: <*.mm>

Are you sure that's safe? Isn't that some C++ mongrel? Does "Objective C++" have the same rules as C++11 in this regard?
paveljanik commented at 8:21 AM on August 17, 2017: contributor

See e.g. Apple's sample programs (https://developer.apple.com/library/content/samplecode/GL3_Text/Listings/Sources_Toolkits_OpenGL_Shaders_GLUProgram_mm.html). It should be safe.
laanwj commented at 7:49 AM on August 18, 2017: member

It should be safe.

OK. Just wanted to bring it up.

Seems to need rebase now.
laanwj assigned laanwj on Aug 18, 2017
Document the preference of nullptr over NULL or (void*)0 bea8e9e66e
practicalswift force-pushed on Aug 18, 2017
practicalswift commented at 7:51 AM on August 18, 2017: contributor

Rebased! :-)
laanwj merged this on Aug 18, 2017
laanwj closed this on Aug 18, 2017
laanwj referenced this in commit 9e00a625b4 on Aug 18, 2017
PastaPastaPasta referenced this in commit 3eda56fff5 on Sep 19, 2019
PastaPastaPasta referenced this in commit 91ac93c63f on Sep 23, 2019
PastaPastaPasta referenced this in commit c2171001d5 on Sep 24, 2019
PastaPastaPasta referenced this in commit 77523f121f on Nov 19, 2019
PastaPastaPasta referenced this in commit 1d3f9a70b8 on Nov 21, 2019
PastaPastaPasta referenced this in commit 47a0b82324 on Dec 9, 2019
PastaPastaPasta referenced this in commit 1b943d67ea on Jan 1, 2020
PastaPastaPasta referenced this in commit 9d58c98753 on Jan 2, 2020
ckti referenced this in commit d7d0d4db21 on Mar 28, 2021
practicalswift deleted the branch on Apr 10, 2021
gades referenced this in commit 651b72418a on Jun 26, 2021
gades referenced this in commit 4dd3ea416b on Feb 22, 2022
DrahtBot locked this on Aug 18, 2022

Contributors

Labels

Linked (view graph)

#10483 scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL #10645 Use nullptr (C++11) instead of zero (0) as the null pointer constant