Remove unused function arguments #13554

pull practicalswift wants to merge 3 commits into bitcoin:master from practicalswift:remove-unused-function-arguments changing 3 files +8 −8

practicalswift commented at 9:34 PM on June 27, 2018: contributor

Remove unused function arguments.
fanquake added the label Refactoring on Jun 27, 2018
Empact commented at 11:09 PM on June 27, 2018: member

utACK 796c9e3
ken2812221 commented at 7:48 AM on June 28, 2018: contributor

utACK 796c9e371c30bb5cada70decaa027edbb4ad078f
DrahtBot commented at 9:28 AM on June 28, 2018: member
Note to reviewers: This pull request conflicts with the following ones:
- #13062 (Make script interpreter independent from storage type CScript by sipa)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
promag commented at 9:37 AM on June 28, 2018: member

utACK 796c9e3. @practicalswift have you checked if these arguments were used in the past?
practicalswift commented at 8:29 AM on June 30, 2018: contributor
@promag Yes absolutely, these were the results:
- ThreadHTTP: argument never used.
- DefaultOptions: argument never used.
- ProcessGetBlockData: last use of interruptMsgProc removed in 66aa1d58a158991a8014a91335b5bc9c00062f56 (ping @thebluematt :-))
- WitnessSigOps: argument never used.
conscott commented at 12:08 PM on July 2, 2018: contributor

Tested ACK 796c9e371c30bb5cada70decaa027edbb4ad078f
fanquake commented at 1:49 AM on July 3, 2018: member

Concept ACK @practicalswift What are you doing to find the unused arguments? I'm curious because (from a quick glance) there are more functions in those same files that also have unused arguments. Any reason not to include them here?
practicalswift commented at 4:44 PM on July 6, 2018: contributor

@fanquake What additional examples of unused arguments did you find? Let me know and I’ll investigate why the commercial static analyzer I used for this specific analysis missed them.
fanquake commented at 1:47 PM on July 8, 2018: member

@practicalswift See #13615 for one example.
laanwj referenced this in commit 172f984f59 on Jul 9, 2018
MarcoFalke commented at 12:05 PM on July 10, 2018: member

Needs rebase?
Remove unused argument to ThreadHTTP(...) 05dbb0c042
Remove unused argument to DefaultOptions(...) d1d7cfebd2
Remove unused argument to WitnessSigOps(...) bd9d0690dc
practicalswift force-pushed on Jul 10, 2018
practicalswift commented at 4:13 PM on July 10, 2018: contributor

Rebased! :-)
fanquake commented at 1:08 PM on July 15, 2018: member

utACK bd9d069
fanquake added this to the "Mergeable" column in a project