refactoring: Remove unreferenced local variables #14094

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:msvc-warnings changing 5 files +8 −9
  1. practicalswift commented at 8:06 PM on August 28, 2018: contributor

    Remove unreferenced local variables:

    Increase signal to noise in appveyor build output by reducing the MSVC warning count from 12 to 4. 12 is the number of MSVC warnings under our current appveyor setup assuming the changes in #14086 are also implemented.

    This makes it easier to spot errors or more important warnings in the verbose appveyor output. MSVC warnings are good, so having access to them in a noise free way (read: without trivial warnings) via appveyor without having to use Windows is really valuable.

    See #14086 (comment) plus discussion for context.

    Before:

    c:\projects\bitcoin\src\script\script.cpp(272): warning C4018: '>': signed/unsigned mismatch [C:\projects\bitcoin\build_msvc\libbitcoinconsensus\libbitcoinconsensus.vcxproj]
    c:\projects\bitcoin\src\rest.cpp(467): warning C4101: 'e': unreferenced local variable [C:\projects\bitcoin\build_msvc\libbitcoin_server\libbitcoin_server.vcxproj]
    c:\projects\bitcoin\src\test\allocator_tests.cpp(147): warning C4312: 'reinterpret_cast': conversion from 'int' to 'void *' of greater size [C:\projects\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
    c:\projects\bitcoin\src\test\coins_tests.cpp(511): warning C4101: 'e': unreferenced local variable [C:\projects\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
    c:\projects\bitcoin\src\test\coins_tests.cpp(524): warning C4101: 'e': unreferenced local variable [C:\projects\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
    c:\projects\bitcoin\src\test\coins_tests.cpp(722): warning C4101: 'e': unreferenced local variable [C:\projects\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
    c:\projects\bitcoin\src\test\coins_tests.cpp(783): warning C4101: 'e': unreferenced local variable [C:\projects\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
    c:\projects\bitcoin\src\test\crypto_tests.cpp(535): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) [C:\projects\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
    c:\projects\bitcoin\src\test\dbwrapper_tests.cpp(265): warning C4101: 'e': unreferenced local variable [C:\projects\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
    c:\projects\bitcoin\src\test\net_tests.cpp(118): warning C4101: 'e': unreferenced local variable [C:\projects\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
    c:\projects\bitcoin\src\test\net_tests.cpp(151): warning C4101: 'e': unreferenced local variable [C:\projects\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
    c:\projects\bitcoin\src\test\scheduler_tests.cpp(57): warning C4305: 'argument': truncation from 'int' to 'bool' [C:\projects\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
    

    After:

    c:\projects\bitcoin\src\script\script.cpp(272): warning C4018: '>': signed/unsigned mismatch [C:\projects\bitcoin\build_msvc\libbitcoinconsensus\libbitcoinconsensus.vcxproj]
    c:\projects\bitcoin\src\test\allocator_tests.cpp(147): warning C4312: 'reinterpret_cast': conversion from 'int' to 'void *' of greater size [C:\projects\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
    c:\projects\bitcoin\src\test\crypto_tests.cpp(535): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) [C:\projects\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
    c:\projects\bitcoin\src\test\scheduler_tests.cpp(57): warning C4305: 'argument': truncation from 'int' to 'bool' [C:\projects\bitcoin\build_msvc\test_bitcoin\test_bitcoin.vcxproj]
    
  2. DrahtBot commented at 8:11 PM on August 28, 2018: member

    <!--e57a25ab6845829454e8d69fc972939a-->No more conflicts as of last run.

  3. fanquake added the label Tests on Aug 28, 2018
  4. practicalswift renamed this:
    Increase signal to noise in appveyor build output by reducing the MSVC warning count from 12 to 4
    tests: Increase signal to noise in appveyor build output by reducing the MSVC warning count from 12 to 4
    on Aug 28, 2018
  5. MarcoFalke renamed this:
    tests: Increase signal to noise in appveyor build output by reducing the MSVC warning count from 12 to 4
    tests: Remove unreferenced local variables
    on Aug 29, 2018
  6. MarcoFalke added the label Refactoring on Aug 29, 2018
  7. MarcoFalke renamed this:
    tests: Remove unreferenced local variables
    Remove unreferenced local variables
    on Aug 29, 2018
  8. MarcoFalke renamed this:
    Remove unreferenced local variables
    refactoring: Remove unreferenced local variables
    on Aug 29, 2018
  9. MarcoFalke removed the label Tests on Aug 29, 2018
  10. Empact commented at 6:59 AM on September 2, 2018: member

    utACK 14e8ecc

  11. leishman commented at 9:03 PM on September 2, 2018: contributor

    utACK b0ac1d3

  12. Empact commented at 5:42 PM on September 3, 2018: member

    re-utACK b0ac1d3 squash please

  13. Increase signal to noise in appveyor build output by reducing the MSVC warning count from 12 to 4 (12 is assuming the changes in #14086 are also implemented).
    This makes it easier to spot errors or more important warnings in the verbose appveyor output.
    
    See https://github.com/bitcoin/bitcoin/pull/14086#issuecomment-416610313 plus discussion for context.
    8ecaee13f7
  14. practicalswift force-pushed on Sep 3, 2018
  15. practicalswift commented at 5:54 PM on September 3, 2018: contributor

    Squashed! @leishman @Empact Please re-review :-)

  16. ken2812221 commented at 4:26 AM on September 4, 2018: contributor

    utACK 8ecaee1

  17. leishman commented at 4:52 AM on September 4, 2018: contributor

    utACK 8ecaee1

  18. fanquake commented at 9:38 AM on September 4, 2018: member

    utACK 8ecaee1

  19. laanwj merged this on Sep 4, 2018
  20. laanwj closed this on Sep 4, 2018

  21. laanwj referenced this in commit 564385f4bf on Sep 4, 2018
  22. deadalnix referenced this in commit 1b1bc9407a on Feb 6, 2020
  23. practicalswift deleted the branch on Apr 10, 2021
  24. Munkybooty referenced this in commit 27bd42c323 on Jul 1, 2021
  25. PastaPastaPasta referenced this in commit 2eb2051139 on Jul 19, 2021
  26. PastaPastaPasta referenced this in commit eeae2fcff5 on Jul 19, 2021
  27. PastaPastaPasta referenced this in commit 7152b78113 on Jul 19, 2021
  28. PastaPastaPasta referenced this in commit f0c65f2917 on Jul 19, 2021
  29. dzutto referenced this in commit 93f831a69d on Sep 24, 2021
  30. dzutto referenced this in commit c169600ea2 on Sep 24, 2021
  31. dzutto referenced this in commit 4589d0ce38 on Sep 24, 2021
  32. dzutto referenced this in commit 84210d4187 on Sep 27, 2021
  33. dzutto referenced this in commit 38d928e9c6 on Sep 30, 2021
  34. UdjinM6 referenced this in commit 4c72a1a975 on Oct 1, 2021
  35. kittywhiskers referenced this in commit 6d1bf50e30 on Oct 12, 2021
  36. DrahtBot locked this on Aug 18, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-16 15:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me