test: Run invalid_txs.InputMissing test in feature

MarcoFalke commented at 12:44 pm on January 4, 2019: member

fanquake added the label Tests on Jan 4, 2019

in test/functional/feature_block.py:150 in fa73d4005a outdated

152             badtx = template.get_tx()
153-            self.sign_tx(badtx, attempt_spend_tx)
154+            if TxTemplate != invalid_txs.InputMissing:
155+                self.sign_tx(badtx, attempt_spend_tx)
156+            else:
157+               # Segwit is active in regtest at this point, so to deserialze a

promag commented at 12:52 pm on January 4, 2019:

typo “deserialze”.

in test/functional/feature_block.py:156 in fa73d4005a outdated

158+               # transaction without any inputs correctly, we set the outputs
159+               # to an empty list. This is a hack, as the serialization of an
160+               # empty list of outputs is deserialized as flags==0 and thus
161+               # deserialization of the outputs is skipped.
162+               # Though, it works for the purpose that both sides calculate the
163+               # same tx hash in the merkle tree

ryanofsky commented at 4:50 pm on January 4, 2019:

Not familiar with this test, but just reading the comment, it makes me wonder what outputs were previously in badtx.vout, and why they were generated to begin with if they can be discarded here. If it would make the hack slightly less hacky to avoid generating the outputs originally, or if there is a reason outputs just aren’t important, it would be nice to state this in the comment.

ryanofsky approved

ryanofsky commented at 4:53 pm on January 4, 2019: member

utACK faccf2b098b5c3ed76e4aa8c2161f84b68a8086a. This fixes lint warning, enables a disabled test, and solves an ancient mystery from feature_block test comments.

jamesob approved

jamesob commented at 6:13 pm on January 4, 2019: member

utACK https://github.com/bitcoin/bitcoin/pull/15102/commits/faccf2b098b5c3ed76e4aa8c2161f84b68a8086a

test: Run invalid_txs.InputMissing test in feature_block fac4e731a8

in test/functional/feature_block.py:150 in faccf2b098 outdated

152             badtx = template.get_tx()
153-            self.sign_tx(badtx, attempt_spend_tx)
154+            if TxTemplate != invalid_txs.InputMissing:
155+                self.sign_tx(badtx, attempt_spend_tx)
156+            else:
157+               # Segwit is active in regtest at this point, so to deserialize a