Update assumevalid, minimumchainwork, and getchaintxstats to height 563378 #15429

pull gmaxwell wants to merge 1 commits into bitcoin:master from gmaxwell:201902-assumevalid changing 1 files +6 −6
  1. gmaxwell commented at 3:42 AM on February 17, 2019: contributor

    m_assumed_blockchain_size/m_assumed_chain_state_size were still accurate.

  2. Update assumevalid, minimumchainwork, and getchaintxstats to height 563378.
    m_assumed_blockchain_size/m_assumed_chain_state_size were still accurate.
    a083f75ba7
  3. fanquake added the label Validation on Feb 17, 2019
  4. fanquake added this to the milestone 0.18.0 on Feb 17, 2019
  5. practicalswift commented at 8:10 AM on February 17, 2019: contributor

    utACK a083f75ba79d465f15fddba7b00ca02e31bb3d40

  6. fanquake commented at 12:42 PM on February 17, 2019: member

    tACK a083f75

    bitcoin-cli getchaintxstats 4096 0000000000000000000f1c54590ee18d15ec70e68c8cd4cfbadb1b4f11697eee

    {
      "time": 1550374134, // matches 👍 
      "txcount": 383732546, // matches 👍 
      "window_final_block_hash": "0000000000000000000f1c54590ee18d15ec70e68c8cd4cfbadb1b4f11697eee",
      "window_block_count": 4096,
      "window_tx_count": 8872107,
      "window_interval": 2407303,
      "txrate": 3.685496590998308 // matches 👍 
    }
    

    bitcoin-cli getblock 0000000000000000000f1c54590ee18d15ec70e68c8cd4cfbadb1b4f11697eee

     "height": 563378,
    <.. snip ..>
     "time": 1550374134,
      "mediantime": 1550373349,
      "nonce": 3355453177,
      "bits": "172e6f88",
      "difficulty": 6061518831027.271,
      // matches 👍 
      "chainwork": "0000000000000000000000000000000000000000051dc8b82f450202ecb3d471",
      "nTx": 359,
      "previousblockhash": "00000000000000000001827a07f51769246d852e63c413bc2cd5caa104970f3f",
      "nextblockhash": "0000000000000000001d6cf3d8d1bf2e0b1883f6684bb2dddcb57a5d4c81ec7f"
    

    Relevant IRC chat (line 120):

    120 2019-02-17T03:42:58 bitcoin-git: [bitcoin] gmaxwell opened pull request #15429: Update assumevalid, minimumchainwork, and getchaintxstats to height 563378 (master...201902-assumevalid) #15429 122 2019-02-17T03:43:04 gmaxwell: sipa: as requested, #15429 you might want to 0.18 tag. 123 2019-02-17T03:45:31 echeveria: gmaxwell: isn't the block hash usually set back a bit from the tip? 124 2019-02-17T03:45:45 echeveria: the one in the pull request is approximately now. 125 2019-02-17T03:48:59 fanquake: by the time that PR gets merged, and then 0.18.0 released, it should be back from the tip. testnet is usually set back a larger amount. 126 2019-02-17T03:49:57 echeveria: right, sure 129 2019-02-17T04:03:11 gmaxwell: echeveria: it will be by the time it gets merged. 130 2019-02-17T04:04:04 gmaxwell: IIRC the first time I did it I set it further back, but then noticed how long it took to get merged, since then I've set it right at the tip after first looking to see if I could find a competing block

  7. laanwj commented at 9:53 AM on February 18, 2019: member

    utACK a083f75ba79d465f15fddba7b00ca02e31bb3d40, thanks

  8. laanwj merged this on Feb 18, 2019
  9. laanwj closed this on Feb 18, 2019

  10. laanwj referenced this in commit f5a623eb66 on Feb 18, 2019
  11. jnewbery commented at 7:31 PM on February 19, 2019: member

    ACK a083f75ba79d465f15fddba7b00ca02e31bb3d40 . Matches output on my node.

  12. moneyball commented at 1:10 AM on February 21, 2019: contributor

    ACK a083f75 . Matches output on my node as well. I ran the commands that @fanquake posted above and verified those #s matched what is in the commit. I'm not familiar enough with the system to ensure anything else needs to be verified but at least these numbers match.

  13. DrahtBot locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-18 21:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me